You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Smith (Code Review)" <ge...@cloudera.org> on 2022/12/14 21:56:56 UTC
[Impala-ASF-CR] IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
Michael Smith has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19361
Change subject: IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
......................................................................
IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
Pins the versions maven plugin to 2.13.0 to avoid
https://github.com/mojohaus/versions/issues/848, which causes our
all-build-options run to fail.
Change-Id: I7c3e9dd70ca21e4a325fafd16d305af89bb2369b
---
M bin/jenkins/build-all-flag-combinations.sh
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/19361/1
--
To view, visit http://gerrit.cloudera.org:8080/19361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7c3e9dd70ca21e4a325fafd16d305af89bb2369b
Gerrit-Change-Number: 19361
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
[Impala-ASF-CR] IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/19361 )
Change subject: IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
......................................................................
Patch Set 1: Code-Review+2
This seems like a reasonable emergency measure. I started an all-build-options with master here to see what happens: https://jenkins.impala.io/job/all-build-options-ub1604/9142/
But we don't really need to wait for that. If we want to revert this later, we can.
--
To view, visit http://gerrit.cloudera.org:8080/19361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3e9dd70ca21e4a325fafd16d305af89bb2369b
Gerrit-Change-Number: 19361
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Dec 2022 00:11:36 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19361 )
Change subject: IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
......................................................................
Patch Set 1:
I kicked off https://jenkins.impala.io/job/all-build-options-ub1604/9140/, which should be the only build impacted by this change.
--
To view, visit http://gerrit.cloudera.org:8080/19361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3e9dd70ca21e4a325fafd16d305af89bb2369b
Gerrit-Change-Number: 19361
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 22:20:39 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19361 )
Change subject: IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12034/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3e9dd70ca21e4a325fafd16d305af89bb2369b
Gerrit-Change-Number: 19361
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 22:16:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19361 )
Change subject: IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
......................................................................
Patch Set 1:
all-build-options build passed.
--
To view, visit http://gerrit.cloudera.org:8080/19361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3e9dd70ca21e4a325fafd16d305af89bb2369b
Gerrit-Change-Number: 19361
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Wed, 14 Dec 2022 23:56:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19361 )
Change subject: IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c3e9dd70ca21e4a325fafd16d305af89bb2369b
Gerrit-Change-Number: 19361
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Thu, 15 Dec 2022 00:16:15 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19361 )
Change subject: IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
......................................................................
IMPALA-11800: Pin versions:set to 2.13.0 to avoid regression
Pins the versions maven plugin to 2.13.0 to avoid
https://github.com/mojohaus/versions/issues/848, which causes our
all-build-options run to fail.
Change-Id: I7c3e9dd70ca21e4a325fafd16d305af89bb2369b
Reviewed-on: http://gerrit.cloudera.org:8080/19361
Reviewed-by: Joe McDonnell <jo...@cloudera.com>
Tested-by: Michael Smith <mi...@cloudera.com>
---
M bin/jenkins/build-all-flag-combinations.sh
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Joe McDonnell: Looks good to me, approved
Michael Smith: Verified
--
To view, visit http://gerrit.cloudera.org:8080/19361
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I7c3e9dd70ca21e4a325fafd16d305af89bb2369b
Gerrit-Change-Number: 19361
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>