You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2022/06/13 14:46:42 UTC

[GitHub] [camel] yvesdm opened a new pull request, #7771: Update test.adoc

yvesdm opened a new pull request, #7771:
URL: https://github.com/apache/camel/pull/7771

   Fix typo in documentation. Return type is RouteBuilder and not RoutesBuilder


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus commented on pull request #7771: Update test.adoc

Posted by GitBox <gi...@apache.org>.
davsclaus commented on PR #7771:
URL: https://github.com/apache/camel/pull/7771#issuecomment-1154719558

   Thanks closing this as the current docs is correct


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] yvesdm commented on a diff in pull request #7771: Update test.adoc

Posted by GitBox <gi...@apache.org>.
yvesdm commented on code in PR #7771:
URL: https://github.com/apache/camel/pull/7771#discussion_r895838888


##########
components/camel-test/camel-test/src/main/docs/test.adoc:
##########
@@ -42,7 +42,7 @@ public class SimpleMockTest extends CamelTestSupport {
     }
 
     @Override
-    protected RoutesBuilder createRouteBuilder() throws Exception {
+    protected RouteBuilder createRouteBuilder() throws Exception {

Review Comment:
   Indeed, you a right. I through it was a mistake since we build a new RouteBuilder[] and I got an error from mi IDE.
   So I first through a copy/paste typo mistake instead of a class required to be imported...
   One of my learned of the day ;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #7771: Update test.adoc

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7771:
URL: https://github.com/apache/camel/pull/7771#issuecomment-1154017595

   :warning: This PR changes Camel components and will be tested automatically.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] essobedo commented on a diff in pull request #7771: Update test.adoc

Posted by GitBox <gi...@apache.org>.
essobedo commented on code in PR #7771:
URL: https://github.com/apache/camel/pull/7771#discussion_r895817064


##########
components/camel-test/camel-test/src/main/docs/test.adoc:
##########
@@ -42,7 +42,7 @@ public class SimpleMockTest extends CamelTestSupport {
     }
 
     @Override
-    protected RoutesBuilder createRouteBuilder() throws Exception {
+    protected RouteBuilder createRouteBuilder() throws Exception {

Review Comment:
   Seems to be correct as it is as you can see https://github.com/apache/camel/blob/main/components/camel-test/camel-test/src/main/java/org/apache/camel/test/junit4/CamelTestSupport.java#L878



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] github-actions[bot] commented on pull request #7771: Update test.adoc

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #7771:
URL: https://github.com/apache/camel/pull/7771#issuecomment-1154088641

   :heavy_check_mark: Finished component verification: 0 component(s) test failed out of **1 component(s) tested**


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] yvesdm commented on a diff in pull request #7771: Update test.adoc

Posted by GitBox <gi...@apache.org>.
yvesdm commented on code in PR #7771:
URL: https://github.com/apache/camel/pull/7771#discussion_r895838888


##########
components/camel-test/camel-test/src/main/docs/test.adoc:
##########
@@ -42,7 +42,7 @@ public class SimpleMockTest extends CamelTestSupport {
     }
 
     @Override
-    protected RoutesBuilder createRouteBuilder() throws Exception {
+    protected RouteBuilder createRouteBuilder() throws Exception {

Review Comment:
   Indeed, you a right. I through it was a mistake since we build a new RouteBuilder[] and I got an error from my IDE.
   So I first through a copy/paste typo mistake instead of a class required to be imported...
   One of my learned of the day ;)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [camel] davsclaus closed pull request #7771: Update test.adoc

Posted by GitBox <gi...@apache.org>.
davsclaus closed pull request #7771: Update test.adoc
URL: https://github.com/apache/camel/pull/7771


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org