[jira] [Comment Edited] (KAFKA-1513) Cleanup KafkaServerStartable code

["Evgeny Vereshchagin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/KAFKA-1513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14050303#comment-14050303 ] 

Evgeny Vereshchagin edited comment on KAFKA-1513 at 7/2/14 4:41 PM:
--------------------------------------------------------------------

Yes, It's ok.
I want to remove type declaration (server: *KafkaServer* = new KafkaServer) because it's type obvious by constructor name.
I can't find in guide recommends about type inference usage.
Drop it or explicit better than implicit?


was (Author: evvers):
Yes, It's ok.
I want to remove type declaration (: KafkaServer) because type it's obvious by constructor name.
I can't find in guide recommends about type inference usage.
Drop it or explicit better than implicit?

> Cleanup KafkaServerStartable code
> ---------------------------------
>
>                 Key: KAFKA-1513
>                 URL: https://issues.apache.org/jira/browse/KAFKA-1513
>             Project: Kafka
>          Issue Type: Improvement
>          Components: core
>            Reporter: Evgeny Vereshchagin
>            Priority: Minor
>         Attachments: cleanup-kafkaserverstartable-code-v1.patch
>
>
> [init method|https://github.com/apache/kafka/blob/0.8.1/core/src/main/scala/kafka/server/KafkaServerStartable.scala#L26] too hard to understand.
> Var initialization would be simpler for readers.
> Patch will be soon. It's my first time:)



--
This message was sent by Atlassian JIRA
(v6.2#6252)