You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/05/06 12:35:00 UTC
[GitHub] [superset] ebaratte opened a new pull request, #19977: fix(word-cloud): fix randomness of each word's rotation
ebaratte opened a new pull request, #19977:
URL: https://github.com/apache/superset/pull/19977
### SUMMARY
In `random` and `square` mode, the words rotation of a word cloud chart should be assigned randomly, and be different for each word. Before this PR, all words use the same rotation (derived from the first randomly generated number by seedRandom()).
This PR fixes that behaviour, and restores the randomness of each word's rotation.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
**Before:**
--
**After:**
### TESTING INSTRUCTIONS
Create a word cloud chart, and select a square or random rotation. Ensure all words have different rotations.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ merged pull request #19977: fix(word-cloud): fix randomness of each word's rotation
Posted by GitBox <gi...@apache.org>.
stephenLYZ merged PR #19977:
URL: https://github.com/apache/superset/pull/19977
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #19977: fix(word-cloud): fix randomness of each word's rotation
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #19977:
URL: https://github.com/apache/superset/pull/19977#issuecomment-1123097149
# [Codecov](https://codecov.io/gh/apache/superset/pull/19977?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#19977](https://codecov.io/gh/apache/superset/pull/19977?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5784212) into [master](https://codecov.io/gh/apache/superset/commit/f144de4ee2bf213bb7e17f903bd3975d504c4136?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f144de4) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head 5784212 differs from pull request most recent head 1ef3386. Consider uploading reports for the commit 1ef3386 to get more accurate results
```diff
@@ Coverage Diff @@
## master #19977 +/- ##
==========================================
- Coverage 66.29% 66.29% -0.01%
==========================================
Files 1712 1712
Lines 63962 63963 +1
Branches 6731 6731
==========================================
Hits 42404 42404
- Misses 19847 19848 +1
Partials 1711 1711
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.28% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/19977?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ns/plugin-chart-word-cloud/src/chart/WordCloud.tsx](https://codecov.io/gh/apache/superset/pull/19977/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtd29yZC1jbG91ZC9zcmMvY2hhcnQvV29yZENsb3VkLnRzeA==) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/19977?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/19977?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [f144de4...1ef3386](https://codecov.io/gh/apache/superset/pull/19977?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org