You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@arrow.apache.org by "Wes McKinney (JIRA)" <ji...@apache.org> on 2018/12/27 19:03:00 UTC

[jira] [Commented] (ARROW-4123) [C++] Improve linting workflow and documentation for Windows-based developers

    [ https://issues.apache.org/jira/browse/ARROW-4123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16729788#comment-16729788 ] 

Wes McKinney commented on ARROW-4123:
-------------------------------------

cpplint cannot be run at all on Windows in its current form. We also need to be careful about how we invoke cpplint because Windows can't handle long commands (over 8191 characters, apparently)

Given that we have a list of cpplint exclusions in cpp/CMakeLists.txt already, and we are parallelizing cpplint with xargs, it would make sense to write a build-support/run_cpplint.py that takes an exclusions file, path to the cpplint script or executable, and parallelism options

> [C++] Improve linting workflow and documentation for Windows-based developers
> -----------------------------------------------------------------------------
>
>                 Key: ARROW-4123
>                 URL: https://issues.apache.org/jira/browse/ARROW-4123
>             Project: Apache Arrow
>          Issue Type: Improvement
>          Components: C++
>            Reporter: Wes McKinney
>            Priority: Major
>             Fix For: 0.13.0
>
>
> It is challenging to run the clang-format and cpplint checks on Windows out of the box, and it is not documented how to do so. I found that neither the {{format}} nor {{lint}} targets work correctly when building with Visual Studio 2015. We could use Docker, of course, but it would be nice to be able to run these tools natively on Windows



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)