[GitHub] [incubator-druid] clintropolis commented on a change in pull request #7784: Add finalizeAsBase64Binary option to FixedBucketsHistogramAggregatorFactory

[GitBox <gi...@apache.org>]

clintropolis commented on a change in pull request #7784: Add finalizeAsBase64Binary option to FixedBucketsHistogramAggregatorFactory
URL: https://github.com/apache/incubator-druid/pull/7784#discussion_r291376151
 
 

 ##########
 File path: docs/content/development/extensions-core/approximate-histograms.md
 ##########
 @@ -124,6 +124,7 @@ For general histogram and quantile use cases, the [DataSketches Quantiles Sketch
 |`upperLimit`|Upper limit of the histogram. |No default, must be specified|
 |`numBuckets`|Number of buckets for the histogram. The range [lowerLimit, upperLimit] will be divided into `numBuckets` intervals of equal size.|10|
 |`outlierHandlingMode`|Specifies how values outside of [lowerLimit, upperLimit] will be handled. Supported modes are "ignore", "overflow", and "clip". See [outlier handling modes](#outlier-handling-modes) for more details.|No default, must be specified|
+|`finalizeAsBase64Binary`|If true, the finalized aggregator value will be a Base64-encoded byte array containing the [serialized form](#serialization-formats) of the histogram. If false, the finalized aggregator value will be a JSON representation of the histogram.|false|
 
 Review comment:
   Hmm, I actually sort of think this property should be flipped around since many other complex types will serialize as base64 by default, and the user should opt in to the friendly output. This would keep default behavior consistent for all complex types.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org