You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ksakellis <gi...@git.apache.org> on 2014/12/01 20:02:53 UTC

[GitHub] spark pull request: [SPARK-4079] [CORE] Consolidates Errors if a C...

Github user ksakellis commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3119#discussion_r21111000
  
    --- Diff: core/src/main/scala/org/apache/spark/io/CompressionCodec.scala ---
    @@ -42,27 +43,37 @@ trait CompressionCodec {
       def compressedOutputStream(s: OutputStream): OutputStream
     
       def compressedInputStream(s: InputStream): InputStream
    -}
     
    +  def isAvailable() : Boolean = true
    --- End diff --
    
    oh geez. thanks for the link. it makes sense but yes, not what you would expect from traits. I'll update the pr.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org