[jira] Commented: (OFBIZ-3623) XHTML validation errors (framework/widget)

["Bilgin Ibryam (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-3623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853247#action_12853247 ] 

Bilgin Ibryam commented on OFBIZ-3623:
--------------------------------------

Blas,

in rev 930670 I removed double ampersands from autoCompleterTarget because it was breaking the lookup autocompleter.
Why do we need double ampersands there in case that autoCompleterTarget  is not a real url, but part of javscript code?

Bilgin

> XHTML validation errors (framework/widget)
> ------------------------------------------
>
>                 Key: OFBIZ-3623
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-3623
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>    Affects Versions: SVN trunk
>            Reporter: Blas Rodriguez Somoza
>            Assignee: Adrian Crum
>            Priority: Trivial
>             Fix For: SVN trunk
>
>         Attachments: OFBIZ-3623_framework_widget_xhtml.diff, OFBIZ-3623_framework_widget_xhtml_v2.diff
>
>
> XHTML validation errors
>     * Unclosed INPUT
>     * attributes without values (checked, selected, disabled, etc)
>     * attribute values without "
>     * Uppercase tags or attributes.
>     * Unencoded ampersands in urls.
> Other errors:
> htmlFormMacroLibrary.ftl
> Line 452. img tag must have src and alt attributes.
> <span id="${id}_indicator" style="display: none" class="indicator"><img /></span>
> htmlScreenMacroLibrary.ftl
> Wrong markup at Line 143. Entity without final ;
> >&nbsp</a></li>
> Changes in java classes:
> MacroFormRenderer.java (renderSortField)
> The sort URL must use encoded ampersands.
> HtmlFormRenderer.java (renderDisplayField)
> The alert style must be included in the class attribute not appear as a attribute name (which is what happens now)
> HtmlMenuRenderer.java (renderMenuOpen, renderMenuClose)
> XHTML don't like empty UL. To avoid that, the renderMenuOpen and renderMenuClose methods need to know how many menu items pass the condition and so will be included.
> ModelMenu.java (public int passConditionCount)
> New method to get how many menu items pass the condition.
> ModelMenuItem (public boolean passCondition)
> New method to get if the menu item pass the condition.
> Patch attached

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.