You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by twalthr <gi...@git.apache.org> on 2016/08/03 12:45:13 UTC
[GitHub] flink pull request #2329: [FLINK-3138] [types] Method References are not sup...
GitHub user twalthr opened a pull request:
https://github.com/apache/flink/pull/2329
[FLINK-3138] [types] Method References are not supported as lambda expressions
Thanks for contributing to Apache Flink. Before you open your pull request, please take the following check list into consideration.
If your changes take all of the items into account, feel free to open your pull request. For more information and/or questions please refer to the [How To Contribute guide](http://flink.apache.org/how-to-contribute.html).
In addition to going through the list, please provide a meaningful description of your changes.
- [x] General
- The pull request references the related JIRA issue ("[FLINK-XXX] Jira title text")
- The pull request addresses only one issue
- Each commit in the PR has a meaningful commit message (including the JIRA id)
- [x] Documentation
- Documentation has been added for new functionality
- Old documentation affected by the pull request has been updated
- JavaDoc for public methods has been added
- [x] Tests & Build
- Functionality added by the pull request is covered by tests
- `mvn clean verify` has been executed successfully locally or a Travis build has passed
This PR fixes a small bug in the TypeExtractor and adds more tests to verify Java 8 method references.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/twalthr/flink FLINK-3138
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/2329.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2329
----
commit c7ed2239022b8ea1b1322054d6a9d4c329034a83
Author: twalthr <tw...@apache.org>
Date: 2016-08-03T12:18:40Z
[FLINK-3138] [types] Method References are not supported as lambda expressions
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2329: [FLINK-3138] [types] Method References are not supported ...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/2329
Looks good to me. Has nice tests and the Travis CI failures are cache/jar file issues, i.e., unrelated.
+1 to merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #2329: [FLINK-3138] [types] Method References are not supported ...
Posted by twalthr <gi...@git.apache.org>.
Github user twalthr commented on the issue:
https://github.com/apache/flink/pull/2329
Thanks Stephan. Merging...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #2329: [FLINK-3138] [types] Method References are not sup...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/2329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---