[GitHub] [solr-sandbox] anshumg commented on a diff in pull request #44: Allow ignoring producer send error.

[GitBox <gi...@apache.org>]

anshumg commented on code in PR #44:
URL: https://github.com/apache/solr-sandbox/pull/44#discussion_r981654254


##########
crossdc-commons/src/main/java/org/apache/solr/crossdc/common/KafkaMirroringSink.java:
##########
@@ -75,7 +77,9 @@ public void submit(MirroredSolrRequest request) throws MirroringException {
             String message = "Unable to enqueue request " + request + ", configured retries is" + conf.getInt(KafkaCrossDcConf.NUM_RETRIES) +
                 " and configured max delivery timeout in ms is " + conf.getInt(KafkaCrossDcConf.DELIVERY_TIMEOUT_MS);
             log.error(message, e);
-            throw new MirroringException(message, e);
+            if (!ignoreProducerSendError) {

Review Comment:
   This will catch all exceptions, right?
   
   Should we only do this for specific cases e.g. when the doc is too big to be submitted?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org