You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2019/11/24 10:42:12 UTC

[GitHub] [cordova-coho] raphinesse opened a new pull request #253: fix(versionutil): produce JS that passes our linting

raphinesse opened a new pull request #253: fix(versionutil): produce JS that passes our linting
URL: https://github.com/apache/cordova-coho/pull/253
 
 
   ### Platforms affected
   All
   
   
   ### Motivation and Context
   <!-- Why is this change required? What problem does it solve? -->
   <!-- If it fixes an open issue, please link to the issue here. -->
   We have recently started to try to lint as many JS files as possible. This includes the platforms' version scripts. Unfortunately `coho` updates them in a form that violates our code style.
   
   Requires test updates from #250 to pass the tests
   
   ### Description
   <!-- Describe your changes in detail -->
   - Pulls out the code to update our platforms' version scripts to one location
   - Updates the version script according to our style guide
   
   
   ### Testing
   <!-- Please describe in detail how you tested your changes. -->
   Passes the refactored tests from #250
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org