[GitHub] [airflow] potiuk commented on a change in pull request #6586: [AIRFLOW-5936] Allow explicit get_pty in SSHOperator

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #6586: [AIRFLOW-5936] Allow explicit get_pty in SSHOperator
URL: https://github.com/apache/airflow/pull/6586#discussion_r347082146
 
 

 ##########
 File path: airflow/contrib/operators/ssh_operator.py
 ##########
 @@ -48,6 +48,9 @@ class SSHOperator(BaseOperator):
     :param environment: a dict of shell environment variables. Note that the
         server will reject them silently if `AcceptEnv` is not set in SSH config.
     :type environment: dict
+    :param get_pty: request a pseudo-terminal from the server. When `get_pty`
+        is enabled, the remote process will be killed upon task timeout.
+    :type get_pty: bool
 
 Review comment:
   It would be great to mention in the comment that get_pty is forced to true when the command starts with 'sudo'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services