You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/05/12 13:50:07 UTC
[GitHub] [incubator-doris] hello-stephen opened a new pull request, #9534: Clean the version.sh file before build, otherwise the version informa…
hello-stephen opened a new pull request, #9534:
URL: https://github.com/apache/incubator-doris/pull/9534
## Problem Summary:
During the testing process, it was found that the recompiled version information of the be was not updated, which made it easy to make mistakes when comparing the version performance during the development and testing process.
It has been modified simply, and there may be a better way to modify it.
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] cambyzju commented on pull request #9534: [bugfix]Clean the version.sh file before build, otherwise the version informa…
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #9534:
URL: https://github.com/apache/incubator-doris/pull/9534#issuecomment-1125627808
> > If you want to release the version, you could run 'sh build.sh --clean' at first, then run 'sh build.sh' to compile and release the version.
> > Most of the time, we test and debug frequently, I personally do not think it is necessary to update the version.
>
> We all agree that the new commit information needs to be packed into the newly compiled package in time. FE is included, but BE is not. In the way of --clean All files will be recompiled, while only 3 files will be recompiled by deleting version.h, which is much faster.
If it is really needed, Does call 'gensrc/script/gen_build_version.sh' better than remove files?
for example:
if [ ${BUILD_BE} -eq 1 ] ; then
${DORIS_HOME}/gensrc/script/gen_build_version.sh --be
...
fi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] cambyzju commented on pull request #9534: [bugfix]Clean the version.sh file before build, otherwise the version informa…
Posted by GitBox <gi...@apache.org>.
cambyzju commented on PR #9534:
URL: https://github.com/apache/incubator-doris/pull/9534#issuecomment-1125576693
If you want to release the version, you could run 'sh build.sh --clean' at first, then run 'sh build.sh' to compile and release the version.
Most of the time, we test and debug frequently, I personally do not think it is necessary to update the version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9534: [bugfix]Clean the version.sh file before build, otherwise the version informa…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9534:
URL: https://github.com/apache/incubator-doris/pull/9534#issuecomment-1125593554
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yiguolei merged pull request #9534: [bugfix]Clean the version.sh file before build, otherwise the version informa…
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #9534:
URL: https://github.com/apache/incubator-doris/pull/9534
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #9534: [bugfix]Clean the version.sh file before build, otherwise the version informa…
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #9534:
URL: https://github.com/apache/incubator-doris/pull/9534#issuecomment-1125593544
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] hello-stephen commented on pull request #9534: [bugfix]Clean the version.sh file before build, otherwise the version informa…
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #9534:
URL: https://github.com/apache/incubator-doris/pull/9534#issuecomment-1125619095
> If you want to release the version, you could run 'sh build.sh --clean' at first, then run 'sh build.sh' to compile and release the version.
>
> Most of the time, we test and debug frequently, I personally do not think it is necessary to update the version.
We all agree that the new commit information needs to be packed into the newly compiled package in time. FE is included, but BE is not. In the way of --clean All files will be recompiled, while only 3 files will be recompiled by deleting version.h, which is much faster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org