You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2020/05/01 21:45:57 UTC
[GitHub] [incubator-pinot] snleee commented on a change in pull request #5325: In SegmentPurger, use table config to generate the segment
snleee commented on a change in pull request #5325:
URL: https://github.com/apache/incubator-pinot/pull/5325#discussion_r418751259
##########
File path: pinot-minion/src/main/java/org/apache/pinot/minion/MinionContext.java
##########
@@ -39,7 +41,7 @@ public static MinionContext getInstance() {
private File _dataDir;
private MinionMetrics _minionMetrics;
- private String _minionVersion;
+ private ZkHelixPropertyStore<ZNRecord> _helixPropertyStore;
Review comment:
+1 for this!
I thought of fetching table config calling controller API. This approach is much simpler :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org