[jira] Commented: (HADOOP-7147) Native code does not build on BSD/OSX

["Erik Steffl (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-7147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12995984#comment-12995984 ] 

Erik Steffl commented on HADOOP-7147:
-------------------------------------

Proposed solution: just make a call to setnetgrent, don't make it a condition, i.e. execute the if block (call to getnetgrent) unconditionally.

Rationale:

As far as I can tell in BSD there is no need to check the setnetgrent for errors, there doesn't seem to be a way to check (based on what BSD man page says) and they don't do it: 

http://lists.freebsd.org/pipermail/freebsd-bugs/2009-March/034497.html

I assume that it's the same way Linux API would work (if setnetgrent fails then getnetgrent doesn't return any users) but it needs to be tested.


> Native code does not build on BSD/OSX
> -------------------------------------
>
>                 Key: HADOOP-7147
>                 URL: https://issues.apache.org/jira/browse/HADOOP-7147
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>
> HADOOP-6864 uses the setnetgrent function in a way which is not compatible with BSD APIs, where the call returns void rather than int. This prevents the native libs from building on OSX, for example.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira