[GitHub] [incubator-pinot] jenniferdai commented on a change in pull request #3900: Refactor in preparation for the ORCRecordReader

[GitBox <gi...@apache.org>]

jenniferdai commented on a change in pull request #3900: Refactor in preparation for the ORCRecordReader
URL: https://github.com/apache/incubator-pinot/pull/3900#discussion_r262179477
 
 

 ##########
 File path: pinot-hadoop/src/main/java/org/apache/pinot/hadoop/job/mapper/SegmentCreationMapper.java
 ##########
 @@ -235,6 +238,12 @@ protected void map(LongWritable key, Text value, Context context)
   }
 
   protected FileFormat getFileFormat(String fileName) {
+    // ORC files do not necessarily have the .orc file extension nor is there a reliable way to decide
 
 Review comment:
   changed the file formatting to bring in a general option

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org