[GitHub] [incubator-iceberg] KazydubB commented on a change in pull request #708: Bump Apache Parquet to 1.11.0

[GitBox <gi...@apache.org>]

KazydubB commented on a change in pull request #708: Bump Apache Parquet to 1.11.0
URL: https://github.com/apache/incubator-iceberg/pull/708#discussion_r368979044
 
 

 ##########
 File path: parquet/src/main/java/org/apache/iceberg/parquet/ParquetWriter.java
 ##########
 @@ -171,8 +191,8 @@ private void startRowGroup() {
     this.nextCheckRecordCount = Math.min(Math.max(recordCount / 2, 100), 10000);
     this.recordCount = 0;
 
-    PageWriteStore pageStore = pageStoreCtor.newInstance(
-        compressor, parquetSchema, props.getAllocator());
+    PageWriteStore pageStore = pageStoreCtorParquet.newInstance(
+          compressor, parquetSchema, props.getAllocator(), Integer.MAX_VALUE);
 
 Review comment:
   This will fail in case of `1.10` as it does not expect the last `int`, isn't it?
   
   Also, why not pass `ParquetProperties.DEFAULT_COLUMN_INDEX_TRUNCATE_LENGTH` instead of `Integer.MAX_VALUE`? It looks like `Integer.MAX_VALUE` is used in test cases only (for this particular value).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org