You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/29 19:07:32 UTC
[GitHub] [airflow] potiuk opened a new pull request, #27368: Fix caching in CI for pre-commits
potiuk opened a new pull request, #27368:
URL: https://github.com/apache/airflow/pull/27368
For some time, caching in pre-commits was broken and some of the pre-commit installation was unnecessary. There were few missing or mis-sequenced steps when the CI cache was declered and it made regular PRs us a bit (1-2 minutes) longer time for pre-commit setup than it was needed. In case of image building, there is no need to setup all pre-commits because only one pre-commit is needed (update-generated dependencies) - instead we can simply install rich and yaml locally and run the pre-comit script directly.
This PR cleans it up.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27368: Fix caching in CI for pre-commits
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27368:
URL: https://github.com/apache/airflow/pull/27368#issuecomment-1295943708
This one shaves about 1m from every "build image" step. The images are build in most commits and there is usually "wait for images" step in the "Pull Request" workflow. This might seem small, but in fact it should make most of our workflow complete faster and - most importantly - block other jobs for quite a bit shorter time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27368: Fix caching in CI for pre-commits
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27368:
URL: https://github.com/apache/airflow/pull/27368#issuecomment-1295945085
It's about 30 seconds in fact for build images - but I think it's entirely worth it:
Before:
<img width="313" alt="Screenshot 2022-10-29 at 21 20 26" src="https://user-images.githubusercontent.com/595491/198849149-e11d50ea-d6ef-48d0-8050-24e71a26ca18.png">
After:
<img width="326" alt="Screenshot 2022-10-29 at 21 20 00" src="https://user-images.githubusercontent.com/595491/198849145-8ffa7e90-2504-49cd-a5ea-108424f5723c.png">
Speeding up static checks is also cool but we will see if it works well only after we merge it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #27368: Fix caching in CI for pre-commits
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27368:
URL: https://github.com/apache/airflow/pull/27368#issuecomment-1295990168
There are cool follow-ups coming (#27369) so let's merge this one quick :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #27368: Fix caching in CI for pre-commits
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27368:
URL: https://github.com/apache/airflow/pull/27368
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org