[GitHub] [incubator-druid] gianm commented on a change in pull request #8196: GroupBy array-based result rows.

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #8196: GroupBy array-based result rows.
URL: https://github.com/apache/incubator-druid/pull/8196#discussion_r309260999
 
 

 ##########
 File path: processing/src/main/java/org/apache/druid/query/groupby/GroupByQueryQueryToolChest.java
 ##########
 @@ -465,9 +513,9 @@ public String apply(DimensionSpec input)
   }
 
   @Override
-  public CacheStrategy<Row, Object, GroupByQuery> getCacheStrategy(final GroupByQuery query)
+  public CacheStrategy<ResultRow, Object, GroupByQuery> getCacheStrategy(final GroupByQuery query)
   {
-    return new CacheStrategy<Row, Object, GroupByQuery>()
+    return new CacheStrategy<ResultRow, Object, GroupByQuery>()
     {
       private static final byte CACHE_STRATEGY_VERSION = 0x1;
 
 Review comment:
   Check out the `prepareForCache` method -- the cache format is the same. It was always array-based, and it remains so.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org