[GitHub] [rocketmq] tsunghanjacktsai commented on a diff in pull request #4551: 【ISSUE #4550】adjust description of GetAclConfg command

[GitBox <gi...@apache.org>]

tsunghanjacktsai commented on code in PR #4551:
URL: https://github.com/apache/rocketmq/pull/4551#discussion_r913333438


##########
tools/src/main/java/org/apache/rocketmq/tools/command/acl/GetAccessConfigSubCommand.java:
##########
@@ -116,8 +115,6 @@ private void printClusterBaseInfo(
                     field.setAccessible(true);
                     if (field.get(config) != null) {
                         System.out.printf("%-1s %-18s: %s\n", "", field.getName(), field.get(config).toString());
-                    } else {

Review Comment:
   I believe leaving it blank makes sense and would not affect its meaning. Do you think it's really necessary to remove it?



##########
tools/src/main/java/org/apache/rocketmq/tools/command/acl/GetAccessConfigSubCommand.java:
##########
@@ -52,20 +52,19 @@ public class GetAccessConfigSubCommand implements SubCommand {
     @Override public Options buildCommandlineOptions(Options options) {
         OptionGroup optionGroup = new OptionGroup();
 
-        Option opt = new Option("b", "brokerAddr", true, "query acl config version for which broker");
+        Option opt = new Option("b", "brokerAddr", true, "query acl config for which broker");

Review Comment:
   Pls help us change the description to "query acl config for specified broker" to make it more formal and consistent with the clusterName one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org