You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/07/15 08:15:43 UTC

[GitHub] [pulsar] equanz opened a new pull request #11323: [C++] Use same regex code at ZTSClient

equanz opened a new pull request #11323:
URL: https://github.com/apache/pulsar/pull/11323


   ### Motivation
   https://github.com/apache/pulsar/pull/9533/files#diff-41a90a5ec7937b5e2151752843621d6acfe8963077dc04c285842a09a4e45ecc causes some degraded behaviors at ZTSClient.
   
   1. when using boost::regex
      - can't set `path` at file scheme
   2. when using std::regex
      - can't set relative path like `file:./path/to/private.key`
   
   I'd like to fix this issue.
   
   ### Modifications
   
   * Use same regex code between boost and std like [this](https://github.com/apache/pulsar/pull/9533/files#diff-a67e917f5f42f3337507a69a4e0f13e286238dc759b4048cb5141290cf445b38)
   * Fix regex to be able to capture relative path like `file:./`
   
   ### Verifying this change
   
   - [ ] Make sure that the change passes the CI checks.
   
   This change added tests and can be verified as follows:
   
   - Add unit tests for `ZTSClientWrapper::parseUri` with relative path
   
   ### Does this pull request potentially affect one of the following parts:
   
   *If `yes` was chosen, please highlight the changes*
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API: (no)
     - The schema: (no)
     - The default values of configurations: (no)
     - The wire protocol: (no)
     - The rest endpoints: (no)
     - The admin cli options: (no)
     - Anything that affects deployment: (no)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] equanz commented on pull request #11323: [C++] Use same regex code at ZTSClient

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #11323:
URL: https://github.com/apache/pulsar/pull/11323#issuecomment-880557393


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] equanz commented on pull request #11323: [C++] Use same regex code at ZTSClient

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #11323:
URL: https://github.com/apache/pulsar/pull/11323#issuecomment-881107139


   @Anonymitaet 
   > (The PR template contains info about doc, which helps others know more about the changes. Can you provide doc info in future PR descriptions? Thanks)
   
   I understand. I updated the description.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] sijie merged pull request #11323: [C++] Use same regex code at ZTSClient

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #11323:
URL: https://github.com/apache/pulsar/pull/11323


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #11323: [C++] Use same regex code at ZTSClient

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11323:
URL: https://github.com/apache/pulsar/pull/11323#issuecomment-881177831


   @equanz many thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #11323: [C++] Use same regex code at ZTSClient

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #11323:
URL: https://github.com/apache/pulsar/pull/11323#issuecomment-881094369


   Thanks for your contribution. For this PR, do we need to update docs?
   
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc info in future PR descriptions? Thanks) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] equanz commented on pull request #11323: [C++] Use same regex code at ZTSClient

Posted by GitBox <gi...@apache.org>.
equanz commented on pull request #11323:
URL: https://github.com/apache/pulsar/pull/11323#issuecomment-880617963


   /pulsarbot run-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org