You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "Tobias Bocanegra (JIRA)" <ji...@apache.org> on 2011/02/07 11:07:30 UTC
[jira] Created: (JCR-2880) Setting a binary property twice discards
blob but does not remove it from changelog
Setting a binary property twice discards blob but does not remove it from changelog
-----------------------------------------------------------------------------------
Key: JCR-2880
URL: https://issues.apache.org/jira/browse/JCR-2880
Project: Jackrabbit Content Repository
Issue Type: Bug
Components: jackrabbit-jcr2spi
Affects Versions: 2.2.2, 2.2.1, 2.2.0
Reporter: Tobias Bocanegra
Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
javax.jcr.RepositoryException: this BLOBFileValue has been disposed
at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-2880) Setting a binary property twice
discards blob but does not remove it from changelog
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991978#comment-12991978 ]
Tobias Bocanegra commented on JCR-2880:
---------------------------------------
from the little debugging i conducted, i think that the first setProperty() adds the state to the "added" collection, and the 2nd to the "modified" collection.
imo this is not correct, the state should remain in the "added" collection only.
> Setting a binary property twice discards blob but does not remove it from changelog
> -----------------------------------------------------------------------------------
>
> Key: JCR-2880
> URL: https://issues.apache.org/jira/browse/JCR-2880
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 2.2.0, 2.2.1, 2.2.2
> Reporter: Tobias Bocanegra
> Attachments: add_bin_twice.patch
>
>
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
> javax.jcr.RepositoryException: this BLOBFileValue has been disposed
> at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
> will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-2880) Save fails after setting a binary
property twice
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela updated JCR-2880:
------------------------
Summary: Save fails after setting a binary property twice (was: Setting a binary property twice discards blob but does not remove it from changelog)
> Save fails after setting a binary property twice
> ------------------------------------------------
>
> Key: JCR-2880
> URL: https://issues.apache.org/jira/browse/JCR-2880
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 2.2.0, 2.2.1, 2.2.2
> Reporter: Tobias Bocanegra
> Attachments: add_bin_twice.patch
>
>
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
> javax.jcr.RepositoryException: this BLOBFileValue has been disposed
> at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
> will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (JCR-2880) Setting a binary property twice discards
blob but does not remove it from changelog
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tobias Bocanegra updated JCR-2880:
----------------------------------
Attachment: add_bin_twice.patch
based on jackrabbit 2.2 branch
> Setting a binary property twice discards blob but does not remove it from changelog
> -----------------------------------------------------------------------------------
>
> Key: JCR-2880
> URL: https://issues.apache.org/jira/browse/JCR-2880
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 2.2.0, 2.2.1, 2.2.2
> Reporter: Tobias Bocanegra
> Attachments: add_bin_twice.patch
>
>
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
> javax.jcr.RepositoryException: this BLOBFileValue has been disposed
> at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
> will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-2880) Save fails after setting a binary
property twice
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tobias Bocanegra updated JCR-2880:
----------------------------------
Fix Version/s: 2.2.5
> Save fails after setting a binary property twice
> ------------------------------------------------
>
> Key: JCR-2880
> URL: https://issues.apache.org/jira/browse/JCR-2880
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 2.2.0, 2.2.1, 2.2.2
> Reporter: Tobias Bocanegra
> Assignee: angela
> Fix For: 2.2.5, 2.3.0
>
> Attachments: add_bin_twice.patch
>
>
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
> javax.jcr.RepositoryException: this BLOBFileValue has been disposed
> at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
> will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (JCR-2880) Save fails after setting a binary
property twice
Posted by "Tobias Bocanegra (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tobias Bocanegra closed JCR-2880.
---------------------------------
thanks. works as expected.
> Save fails after setting a binary property twice
> ------------------------------------------------
>
> Key: JCR-2880
> URL: https://issues.apache.org/jira/browse/JCR-2880
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 2.2.0, 2.2.1, 2.2.2
> Reporter: Tobias Bocanegra
> Assignee: angela
> Fix For: 2.2.5, 2.3.0
>
> Attachments: add_bin_twice.patch
>
>
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
> javax.jcr.RepositoryException: this BLOBFileValue has been disposed
> at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
> will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (JCR-2880) Save fails after setting a binary
property twice
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-2880:
-------------------------------
Fix Version/s: (was: 2.2.5)
2.2.6
> Save fails after setting a binary property twice
> ------------------------------------------------
>
> Key: JCR-2880
> URL: https://issues.apache.org/jira/browse/JCR-2880
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 2.2.0, 2.2.1, 2.2.2
> Reporter: Tobias Bocanegra
> Assignee: angela
> Fix For: 2.2.6, 2.3.0
>
> Attachments: add_bin_twice.patch
>
>
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
> javax.jcr.RepositoryException: this BLOBFileValue has been disposed
> at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
> will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (JCR-2880) Save fails after setting a binary
property twice
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13015808#comment-13015808 ]
angela commented on JCR-2880:
-----------------------------
btw: the problem is not caused by 'added' vs. 'modified'. the same error occurs if you have an existing binary property and modify it twice before saving. imo the cause of the problem is the disposal of the values upon modification. that should be deferred to the completion of the SetProperty operation.
> Save fails after setting a binary property twice
> ------------------------------------------------
>
> Key: JCR-2880
> URL: https://issues.apache.org/jira/browse/JCR-2880
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 2.2.0, 2.2.1, 2.2.2
> Reporter: Tobias Bocanegra
> Attachments: add_bin_twice.patch
>
>
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
> javax.jcr.RepositoryException: this BLOBFileValue has been disposed
> at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
> will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-2880) Setting a binary property twice
discards blob but does not remove it from changelog
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991967#comment-12991967 ]
angela commented on JCR-2880:
-----------------------------
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog
consolidation (or cleanup) of the changelog is not the responsibility of jcr2spi but rather of the SPI implementation.
i assume discarding the previous values is wrong... but will take a closer look at it asap.
> Setting a binary property twice discards blob but does not remove it from changelog
> -----------------------------------------------------------------------------------
>
> Key: JCR-2880
> URL: https://issues.apache.org/jira/browse/JCR-2880
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 2.2.0, 2.2.1, 2.2.2
> Reporter: Tobias Bocanegra
> Attachments: add_bin_twice.patch
>
>
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
> javax.jcr.RepositoryException: this BLOBFileValue has been disposed
> at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
> will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (JCR-2880) Save fails after setting a binary
property twice
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved JCR-2880.
-------------------------
Resolution: Fixed
Fix Version/s: 2.3.0
Assignee: angela
> Save fails after setting a binary property twice
> ------------------------------------------------
>
> Key: JCR-2880
> URL: https://issues.apache.org/jira/browse/JCR-2880
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 2.2.0, 2.2.1, 2.2.2
> Reporter: Tobias Bocanegra
> Assignee: angela
> Fix For: 2.3.0
>
> Attachments: add_bin_twice.patch
>
>
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
> javax.jcr.RepositoryException: this BLOBFileValue has been disposed
> at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
> will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (JCR-2880) Setting a binary property twice
discards blob but does not remove it from changelog
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-2880?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12991981#comment-12991981 ]
angela commented on JCR-2880:
-----------------------------
jcr2spi records all modifications without making any kind of cleanup... it doesn't work the same way as jackrabbit-core.
> Setting a binary property twice discards blob but does not remove it from changelog
> -----------------------------------------------------------------------------------
>
> Key: JCR-2880
> URL: https://issues.apache.org/jira/browse/JCR-2880
> Project: Jackrabbit Content Repository
> Issue Type: Bug
> Components: jackrabbit-jcr2spi
> Affects Versions: 2.2.0, 2.2.1, 2.2.2
> Reporter: Tobias Bocanegra
> Attachments: add_bin_twice.patch
>
>
> Setting a binary property twice discards the blob value of the first property state but does not remove the change from the changelog, resulting in an error on save:
> javax.jcr.RepositoryException: this BLOBFileValue has been disposed
> at org.apache.jackrabbit.core.value.RefCountingBLOBFileValue.copy(RefCountingBLOBFileValue.java:105)
> will attach patch that adds the respective test to the jcr2spi tests.
--
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira