You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Qiang Zhang <zh...@zte.com.cn> on 2017/11/14 08:15:42 UTC

Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/
-----------------------------------------------------------

Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.


Bugs: RANGER-1887
    https://issues.apache.org/jira/browse/RANGER-1887


Repository: ranger


Description
-------

String tagResourceName = serviceDef.getResources().get(0).getName(); case java.lang.IndexOutOfBoundsException in RangerServiceTag.class
And print log error for RangerServiceStorm.class


Diffs
-----

  agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java ce6002b 
  storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java d4dbd7b 


Diff: https://reviews.apache.org/r/63789/diff/1/


Testing
-------

Tested it


Thanks,

Qiang Zhang


Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

Posted by Qiang Zhang <zh...@zte.com.cn>.

> On 十一月 14, 2017, 10:41 a.m., Colm O hEigeartaigh wrote:
> > It's better to write "!serviceDef.getResources().isEmpty()" than "serviceDef.getResources().size() > 0".
> > 
> > What happens if tagResourceName is null. Will "defaultPolicy.getResources().get(tagResourceName)" throw a NPE?

Yes,you are right,!serviceDef.getResources().isEmpty() is better ,And  defaultPolicy.getResources().get(tagResourceName)  On the conditional statement inside " !serviceDef.getResources().isEmpty() "  I hvae updated the patch,please review again.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/#review190928
-----------------------------------------------------------


On 十一月 14, 2017, 11:09 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63789/
> -----------------------------------------------------------
> 
> (Updated 十一月 14, 2017, 11:09 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1887
>     https://issues.apache.org/jira/browse/RANGER-1887
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> String tagResourceName = serviceDef.getResources().get(0).getName(); case java.lang.IndexOutOfBoundsException in RangerServiceTag.class
> And print log error for RangerServiceStorm.class
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java ce6002b 
>   storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java d4dbd7b 
> 
> 
> Diff: https://reviews.apache.org/r/63789/diff/2/
> 
> 
> Testing
> -------
> 
> Tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/#review190928
-----------------------------------------------------------



It's better to write "!serviceDef.getResources().isEmpty()" than "serviceDef.getResources().size() > 0".

What happens if tagResourceName is null. Will "defaultPolicy.getResources().get(tagResourceName)" throw a NPE?

- Colm O hEigeartaigh


On Nov. 14, 2017, 8:15 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63789/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2017, 8:15 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1887
>     https://issues.apache.org/jira/browse/RANGER-1887
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> String tagResourceName = serviceDef.getResources().get(0).getName(); case java.lang.IndexOutOfBoundsException in RangerServiceTag.class
> And print log error for RangerServiceStorm.class
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java ce6002b 
>   storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java d4dbd7b 
> 
> 
> Diff: https://reviews.apache.org/r/63789/diff/1/
> 
> 
> Testing
> -------
> 
> Tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/#review191312
-----------------------------------------------------------



The "String tagResourceName = null" definition could be moved into the if statement, e.g. String tagResourceName = serviceDef.getResources().get(0).getName();

- Colm O hEigeartaigh


On Nov. 17, 2017, 6:16 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63789/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2017, 6:16 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1887
>     https://issues.apache.org/jira/browse/RANGER-1887
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> String tagResourceName = serviceDef.getResources().get(0).getName(); case java.lang.IndexOutOfBoundsException in RangerServiceTag.class
> And print log error for RangerServiceStorm.class
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java ce6002b 
>   storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java d4dbd7b 
> 
> 
> Diff: https://reviews.apache.org/r/63789/diff/3/
> 
> 
> Testing
> -------
> 
> Tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/#review191374
-----------------------------------------------------------


Ship it!




Ship It!

- Alejandro Fernandez


On Nov. 17, 2017, 6:16 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63789/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2017, 6:16 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1887
>     https://issues.apache.org/jira/browse/RANGER-1887
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> String tagResourceName = serviceDef.getResources().get(0).getName(); case java.lang.IndexOutOfBoundsException in RangerServiceTag.class
> And print log error for RangerServiceStorm.class
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java ce6002b 
>   storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java d4dbd7b 
> 
> 
> Diff: https://reviews.apache.org/r/63789/diff/3/
> 
> 
> Testing
> -------
> 
> Tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/#review191557
-----------------------------------------------------------


Ship it!




Ship It!

- pengjianhua


On 十一月 17, 2017, 6:16 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63789/
> -----------------------------------------------------------
> 
> (Updated 十一月 17, 2017, 6:16 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1887
>     https://issues.apache.org/jira/browse/RANGER-1887
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> String tagResourceName = serviceDef.getResources().get(0).getName(); case java.lang.IndexOutOfBoundsException in RangerServiceTag.class
> And print log error for RangerServiceStorm.class
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java ce6002b 
>   storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java d4dbd7b 
> 
> 
> Diff: https://reviews.apache.org/r/63789/diff/3/
> 
> 
> Testing
> -------
> 
> Tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/
-----------------------------------------------------------

(Updated 十一月 17, 2017, 6:16 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.


Bugs: RANGER-1887
    https://issues.apache.org/jira/browse/RANGER-1887


Repository: ranger


Description
-------

String tagResourceName = serviceDef.getResources().get(0).getName(); case java.lang.IndexOutOfBoundsException in RangerServiceTag.class
And print log error for RangerServiceStorm.class


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java ce6002b 
  storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java d4dbd7b 


Diff: https://reviews.apache.org/r/63789/diff/3/

Changes: https://reviews.apache.org/r/63789/diff/2-3/


Testing
-------

Tested it


Thanks,

Qiang Zhang


Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

Posted by Qiang Zhang <zh...@zte.com.cn>.

> On 十一月 16, 2017, 11:36 a.m., Colm O hEigeartaigh wrote:
> > The indentation of the for loop needs to be shifted to the right due to the new if statement.

Thanks for your reminder,I have formatted the code.


- Qiang


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/#review191170
-----------------------------------------------------------


On 十一月 14, 2017, 11:09 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63789/
> -----------------------------------------------------------
> 
> (Updated 十一月 14, 2017, 11:09 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1887
>     https://issues.apache.org/jira/browse/RANGER-1887
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> String tagResourceName = serviceDef.getResources().get(0).getName(); case java.lang.IndexOutOfBoundsException in RangerServiceTag.class
> And print log error for RangerServiceStorm.class
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java ce6002b 
>   storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java d4dbd7b 
> 
> 
> Diff: https://reviews.apache.org/r/63789/diff/3/
> 
> 
> Testing
> -------
> 
> Tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/#review191170
-----------------------------------------------------------



The indentation of the for loop needs to be shifted to the right due to the new if statement.

- Colm O hEigeartaigh


On Nov. 14, 2017, 11:09 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63789/
> -----------------------------------------------------------
> 
> (Updated Nov. 14, 2017, 11:09 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1887
>     https://issues.apache.org/jira/browse/RANGER-1887
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> String tagResourceName = serviceDef.getResources().get(0).getName(); case java.lang.IndexOutOfBoundsException in RangerServiceTag.class
> And print log error for RangerServiceStorm.class
> 
> 
> Diffs
> -----
> 
>   agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java ce6002b 
>   storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java d4dbd7b 
> 
> 
> Diff: https://reviews.apache.org/r/63789/diff/2/
> 
> 
> Testing
> -------
> 
> Tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>


Re: Review Request 63789: RANGER-1887:serviceDef.getResources().get(0).getName(); case IndexOutOfBoundsException in RangerServiceTag.class And print error in RangerServiceStorm

Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/
-----------------------------------------------------------

(Updated 十一月 14, 2017, 11:09 a.m.)


Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.


Bugs: RANGER-1887
    https://issues.apache.org/jira/browse/RANGER-1887


Repository: ranger


Description
-------

String tagResourceName = serviceDef.getResources().get(0).getName(); case java.lang.IndexOutOfBoundsException in RangerServiceTag.class
And print log error for RangerServiceStorm.class


Diffs (updated)
-----

  agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java ce6002b 
  storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java d4dbd7b 


Diff: https://reviews.apache.org/r/63789/diff/2/

Changes: https://reviews.apache.org/r/63789/diff/1-2/


Testing
-------

Tested it


Thanks,

Qiang Zhang