You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Armand Grillet <ag...@mesosphere.io> on 2017/11/10 12:59:52 UTC

Review Request 63723: Upated excluded files by JavaScript linter.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63723/
-----------------------------------------------------------

Review request for mesos, Benjamin Mahler and Kevin Klues.


Bugs: MESOS-7924
    https://issues.apache.org/jira/browse/MESOS-7924


Repository: mesos


Description
-------

See summary.


Diffs
-----

  support/mesos-style.py f2888195fec768db8cb6409288e72c7d1eda0f03 


Diff: https://reviews.apache.org/r/63723/diff/1/


Testing
-------

```
python support/mesos-style.py src/webui/master/static/js/*.js
```


Thanks,

Armand Grillet

Re: Review Request 63723: Upated excluded files by JavaScript linter.

Posted by Kevin Klues <kl...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63723/#review190709
-----------------------------------------------------------




support/mesos-style.py
Lines 305 (patched)
<https://reviews.apache.org/r/63723/#comment268298>

    I think the pailer is something we wrote, so we should lint it and not exclude it here.


- Kevin Klues


On Nov. 10, 2017, 12:59 p.m., Armand Grillet wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63723/
> -----------------------------------------------------------
> 
> (Updated Nov. 10, 2017, 12:59 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Kevin Klues.
> 
> 
> Bugs: MESOS-7924
>     https://issues.apache.org/jira/browse/MESOS-7924
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   support/mesos-style.py f2888195fec768db8cb6409288e72c7d1eda0f03 
> 
> 
> Diff: https://reviews.apache.org/r/63723/diff/1/
> 
> 
> Testing
> -------
> 
> ```
> python support/mesos-style.py src/webui/master/static/js/*.js
> ```
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>