You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2020/09/02 15:06:27 UTC

[GitHub] [zeppelin] zjffdu commented on pull request #3887: [ZEPPELIN-4981]. Zeppelin Client API

zjffdu commented on pull request #3887:
URL: https://github.com/apache/zeppelin/pull/3887#issuecomment-685798108


   
   > First, I think this is a very big PR, and I hope that some others will also review this PR. Overall it seems to be really good. I see that the library [`unirest-java`](https://github.com/Kong/unirest-java) did the communication, this library seems useful.
   > 
   > I have seen that you catch all/most API Exceptions ([example](https://github.com/apache/zeppelin/pull/3887/files#diff-dff367ac423a9016688dc86ee27e4929R430))
   > I think it is better to use an [ExceptionMapper](https://docs.oracle.com/javaee/7/api/javax/ws/rs/ext/ExceptionMapper.html). If not, then you should remove the `throws' declaration.
   
   Thanks for the review @Reamer , I have update the PR to use ExceptionMapper. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org