You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/10/25 22:31:58 UTC

[jira] [Commented] (BEAM-826) Dynamically create subscriptions if unspecified in PubSubIO

    [ https://issues.apache.org/jira/browse/BEAM-826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15606671#comment-15606671 ] 

ASF GitHub Bot commented on BEAM-826:
-------------------------------------

GitHub user tgroh opened a pull request:

    https://github.com/apache/incubator-beam/pull/1190

    [BEAM-826] Generate PubSub Subscriptions during Pipeline Execution

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    
    Instead of generating a random subscription at apply-time, create one
    as required.
    
    If splitIntoBundles is exercised, generate a subscription if there is
    none specified, and create a new PubSub source that uses that
    subscription. This is otherwise identical to the current behavior.
    
    If splitIntoBundles is not exercised, and createReader is called with no
    checkpoint, create a random subscription. Store a reference to this
    subscription is the PubSub checkpoint, including when materialized.
    This changes the wire format of PubSub checkpoints, and
    as such this change is not update-compatible.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/incubator-beam pubsub_generate_subscription_execution

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1190.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1190
    
----
commit f000e02d67f1fb4dfaac6ae4af55f82e60bd6e2f
Author: Thomas Groh <tg...@google.com>
Date:   2016-10-25T21:51:08Z

    Generate PubSub Subscriptions during Pipeline Execution
    
    Instead of generating a random subscription at apply-time, create one
    as required.
    
    If splitIntoBundles is exercised, generate a subscription if there is
    none specified, and create a new PubSub source that uses that
    subscription. This is otherwise identical to the current behavior.
    
    If splitIntoBundles is not exercised, and createReader is called with no
    checkpoint, create a random subscription. Store a reference to this
    subscription is the PubSub checkpoint, including when materialized.
    This changes the wire format of PubSub checkpoints, and
    as such this change is not update-compatible.

----


> Dynamically create subscriptions if unspecified in PubSubIO
> -----------------------------------------------------------
>
>                 Key: BEAM-826
>                 URL: https://issues.apache.org/jira/browse/BEAM-826
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-java-gcp
>            Reporter: Thomas Groh
>            Assignee: Thomas Groh
>
> PubSubIO uses the options to create a random subscription when one is not specified. Move this code to run as part of creating a reader or splitting the source, so it does not use Pipeline-construction-time PipelineOptions.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)