[GitHub] [camel] davsclaus commented on a diff in pull request #7727: CAMEL-18167: camel-aws2-s3 - Show a message when download link url is…

[GitBox <gi...@apache.org>]

davsclaus commented on code in PR #7727:
URL: https://github.com/apache/camel/pull/7727#discussion_r889895889


##########
components/camel-aws/camel-aws2-s3/src/main/java/org/apache/camel/component/aws2/s3/AWS2S3Producer.java:
##########
@@ -579,6 +579,10 @@ private void createDownloadLink(Exchange exchange) {
                 .build();
 
         PresignedGetObjectRequest presignedGetObjectRequest = presigner.presignGetObject(getObjectPresignRequest);
+        if (!presignedGetObjectRequest.isBrowserExecutable()) {

Review Comment:
   So if every message is like this you have a INFO logging per message, that can spam the logs if you have a lot of files to upload.
   
   Either reduce the logging level to DEBUG or we need a way to only log INFO once and then tell that this can happen for other files too. 
   
   Maybe there can be a header added in the response that has this status? Then users can use this in their camel routes as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org