You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Hairong Kuang (JIRA)" <ji...@apache.org> on 2009/03/31 00:37:50 UTC
[jira] Created: (HADOOP-5595) NameNode does not need to run a
replicator to choose a random DataNode
NameNode does not need to run a replicator to choose a random DataNode
----------------------------------------------------------------------
Key: HADOOP-5595
URL: https://issues.apache.org/jira/browse/HADOOP-5595
Project: Hadoop Core
Issue Type: Improvement
Components: dfs
Reporter: Hairong Kuang
Assignee: Hairong Kuang
Fix For: 0.21.0
Attachments: randomDataNode.patch
FSNamesystem#getRandomDatanode uses a replicator to choose a random DataNode. It's an overkill. Instead, Topology#chooseRandom is a much light-weight way to choose a random DataNode from a cluster map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5595) NameNode does not need to run a
replicator to choose a random DataNode
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5595:
----------------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
Failed tasks were not related to this change. The change is too trivial to have a unit test.
> NameNode does not need to run a replicator to choose a random DataNode
> ----------------------------------------------------------------------
>
> Key: HADOOP-5595
> URL: https://issues.apache.org/jira/browse/HADOOP-5595
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: randomDataNode.patch
>
>
> FSNamesystem#getRandomDatanode uses a replicator to choose a random DataNode. It's an overkill. Instead, Topology#chooseRandom is a much light-weight way to choose a random DataNode from a cluster map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5595) NameNode does not need to run a
replicator to choose a random DataNode
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12694380#action_12694380 ]
Hadoop QA commented on HADOOP-5595:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12404187/randomDataNode.patch
against trunk revision 760651.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 Eclipse classpath. The patch retains Eclipse classpath integrity.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
-1 contrib tests. The patch failed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/86/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/86/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/86/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-minerva.apache.org/86/console
This message is automatically generated.
> NameNode does not need to run a replicator to choose a random DataNode
> ----------------------------------------------------------------------
>
> Key: HADOOP-5595
> URL: https://issues.apache.org/jira/browse/HADOOP-5595
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: randomDataNode.patch
>
>
> FSNamesystem#getRandomDatanode uses a replicator to choose a random DataNode. It's an overkill. Instead, Topology#chooseRandom is a much light-weight way to choose a random DataNode from a cluster map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5595) NameNode does not need to run a
replicator to choose a random DataNode
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hairong Kuang updated HADOOP-5595:
----------------------------------
Attachment: randomDataNode.patch
A patch is uploaded.
> NameNode does not need to run a replicator to choose a random DataNode
> ----------------------------------------------------------------------
>
> Key: HADOOP-5595
> URL: https://issues.apache.org/jira/browse/HADOOP-5595
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: randomDataNode.patch
>
>
> FSNamesystem#getRandomDatanode uses a replicator to choose a random DataNode. It's an overkill. Instead, Topology#chooseRandom is a much light-weight way to choose a random DataNode from a cluster map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (HADOOP-5595) NameNode does not need
to run a replicator to choose a random DataNode
Posted by "Hairong Kuang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695150#action_12695150 ]
Hairong Kuang edited comment on HADOOP-5595 at 4/2/09 3:15 PM:
---------------------------------------------------------------
Failed tasks were not related to this change. The change is too trivial to have a unit test.
I've committed this.
was (Author: hairong):
Failed tasks were not related to this change. The change is too trivial to have a unit test.
> NameNode does not need to run a replicator to choose a random DataNode
> ----------------------------------------------------------------------
>
> Key: HADOOP-5595
> URL: https://issues.apache.org/jira/browse/HADOOP-5595
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: randomDataNode.patch
>
>
> FSNamesystem#getRandomDatanode uses a replicator to choose a random DataNode. It's an overkill. Instead, Topology#chooseRandom is a much light-weight way to choose a random DataNode from a cluster map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5595) NameNode does not need to run a
replicator to choose a random DataNode
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12695438#action_12695438 ]
Hudson commented on HADOOP-5595:
--------------------------------
Integrated in Hadoop-trunk #796 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-trunk/796/])
. NameNode does not need to run a replicator to choose a random DataNode. Contributed by Hairong Kuang.
> NameNode does not need to run a replicator to choose a random DataNode
> ----------------------------------------------------------------------
>
> Key: HADOOP-5595
> URL: https://issues.apache.org/jira/browse/HADOOP-5595
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: randomDataNode.patch
>
>
> FSNamesystem#getRandomDatanode uses a replicator to choose a random DataNode. It's an overkill. Instead, Topology#chooseRandom is a much light-weight way to choose a random DataNode from a cluster map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5595) NameNode does not need to run a
replicator to choose a random DataNode
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5595:
-------------------------------------------
Hadoop Flags: [Reviewed]
Status: Patch Available (was: Open)
+1
> NameNode does not need to run a replicator to choose a random DataNode
> ----------------------------------------------------------------------
>
> Key: HADOOP-5595
> URL: https://issues.apache.org/jira/browse/HADOOP-5595
> Project: Hadoop Core
> Issue Type: Improvement
> Components: dfs
> Reporter: Hairong Kuang
> Assignee: Hairong Kuang
> Fix For: 0.21.0
>
> Attachments: randomDataNode.patch
>
>
> FSNamesystem#getRandomDatanode uses a replicator to choose a random DataNode. It's an overkill. Instead, Topology#chooseRandom is a much light-weight way to choose a random DataNode from a cluster map.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.