[GitHub] [incubator-netbeans] bd2019us commented on a change in pull request #1207: Performance Save Patch - Replace replaceAll() with replace()

[GitBox <gi...@apache.org>]

bd2019us commented on a change in pull request #1207: Performance Save Patch - Replace replaceAll() with replace()
URL: https://github.com/apache/incubator-netbeans/pull/1207#discussion_r278674799
 
 

 ##########
 File path: enterprise/glassfish.common/src/org/netbeans/modules/glassfish/common/ProxySettings.java
 ##########
 @@ -157,7 +157,7 @@ private static String getDefaultUserNonProxyHosts () {
     }
 
     private static String getModifiedNonProxyHosts (String systemPreset) {
-        String fromSystem = systemPreset.replaceAll (";", "|").replaceAll (",", "|"); //NOI18N
+        String fromSystem = systemPreset.replace (";", "|").replace (",", "|"); //NOI18N
         String fromUser = getPresetNonProxyHosts () == null ? "" : getPresetNonProxyHosts ().replaceAll (";", "|").replaceAll (",", "|"); //NOI18N
 
 Review comment:
   Thank you for bringing this up. The initial PR we submitted was not comprehensive. This pull request will be updated with a more comprehensive replacement of replaceAll() -> replace() where applicable.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists