[jira] [Commented] (FELIX-5964) TLS doesn't work for anonymous pages

["Antonio Sanso (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FELIX-5964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16647845#comment-16647845 ] 

Antonio Sanso commented on FELIX-5964:
--------------------------------------

attaching simple patch
{code:java}
Index: pom.xml
===================================================================
--- pom.xml    (revision 1843651)
+++ pom.xml    (working copy)
@@ -75,7 +75,7 @@
         <dependency>
             <groupId>org.osgi</groupId>
             <artifactId>org.osgi.service.http.whiteboard</artifactId>
-            <version>1.0.0</version>
+            <version>1.1.0</version>
             <scope>provided</scope>
         </dependency>
         <dependency>
Index: src/main/java/org/apache/felix/http/sslfilter/internal/SslFilter.java
===================================================================
--- src/main/java/org/apache/felix/http/sslfilter/internal/SslFilter.java    (revision 1843651)
+++ src/main/java/org/apache/felix/http/sslfilter/internal/SslFilter.java    (working copy)
@@ -35,10 +35,11 @@
 import javax.servlet.http.HttpServletResponse;
 
 import org.osgi.service.cm.ConfigurationException;
+import org.osgi.service.http.whiteboard.Preprocessor;
 import org.osgi.service.log.LogService;
 
 @SuppressWarnings("rawtypes")
-public class SslFilter implements Filter
+public class SslFilter implements  Preprocessor
 {
     public static final String PID = "org.apache.felix.http.sslfilter.SslFilter";
 
Index: src/main/java/org/apache/felix/http/sslfilter/internal/SslFilterActivator.java
===================================================================
--- src/main/java/org/apache/felix/http/sslfilter/internal/SslFilterActivator.java    (revision 1843651)
+++ src/main/java/org/apache/felix/http/sslfilter/internal/SslFilterActivator.java    (working copy)
@@ -21,8 +21,6 @@
 import java.util.Dictionary;
 import java.util.Hashtable;
 
-import javax.servlet.Filter;
-
 import org.osgi.framework.Bundle;
 import org.osgi.framework.BundleActivator;
 import org.osgi.framework.BundleContext;
@@ -32,6 +30,7 @@
 import org.osgi.service.cm.ConfigurationException;
 import org.osgi.service.cm.ManagedService;
 import org.osgi.service.http.whiteboard.HttpWhiteboardConstants;
+import org.osgi.service.http.whiteboard.Preprocessor;
 import org.osgi.service.log.LogService;
 
 public class SslFilterActivator implements BundleActivator
@@ -84,7 +83,7 @@
         properties.put(HttpWhiteboardConstants.HTTP_WHITEBOARD_CONTEXT_SELECT, "(" + HttpWhiteboardConstants.HTTP_WHITEBOARD_CONTEXT_NAME + "=*)");
         properties.put(HttpWhiteboardConstants.HTTP_WHITEBOARD_FILTER_PATTERN, "/");
 
-        this.filterReg = context.registerService(Filter.class.getName(), filter, properties);
+        this.filterReg = context.registerService(Preprocessor.class.getName(), filter, properties);
 
         SystemLogger.log(LogService.LOG_DEBUG, "SSL filter registered...");
     }{code}

> TLS doesn't work for anonymous pages
> ------------------------------------
>
>                 Key: FELIX-5964
>                 URL: https://issues.apache.org/jira/browse/FELIX-5964
>             Project: Felix
>          Issue Type: Bug
>          Components: HTTP Service
>            Reporter: Antonio Sanso
>            Priority: Minor
>
> Currently the {{SslFilter}} doesn't work with anonymous pages.
> In order to solve this would be enough to leverage the new {{Preprocessor}} feature



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)