You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "urbandan (via GitHub)" <gi...@apache.org> on 2023/05/09 06:13:21 UTC
[GitHub] [kafka] urbandan opened a new pull request, #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
urbandan opened a new pull request, #13690:
URL: https://github.com/apache/kafka/pull/13690
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1540232079
Tests?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] urbandan commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
Posted by "urbandan (via GitHub)" <gi...@apache.org>.
urbandan commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1543482480
Thank you both for the review and the merge - I resolved the JIRA with fix version 3.6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] viktorsomogyi commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
Posted by "viktorsomogyi (via GitHub)" <gi...@apache.org>.
viktorsomogyi commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1541805837
@C0urante I can backport it. Which branches were you thinking of? 3.5, 3.4, 3.3 or should I go back to an earlier release as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] urbandan commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
Posted by "urbandan (via GitHub)" <gi...@apache.org>.
urbandan commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1540445965
Added a unit test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] urbandan commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
Posted by "urbandan (via GitHub)" <gi...@apache.org>.
urbandan commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1539809972
Thanks @viktorsomogyi !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1542437079
We don't have this automated (to my knowledge). For backports, we can cherry-pick and push directly to the branch. PRs aren't necessary but if you'd like a second pair of eyes to, e.g., double-check merge conflict resolution, you can file one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] C0urante commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
Posted by "C0urante (via GitHub)" <gi...@apache.org>.
C0urante commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1542423054
@viktorsomogyi the feature was introduced in 3.3, so that should be far back enough. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] viktorsomogyi merged pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
Posted by "viktorsomogyi (via GitHub)" <gi...@apache.org>.
viktorsomogyi merged PR #13690:
URL: https://github.com/apache/kafka/pull/13690
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] urbandan commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
Posted by "urbandan (via GitHub)" <gi...@apache.org>.
urbandan commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1539486889
@viktorsomogyi can you please take a look at this small fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] viktorsomogyi commented on pull request #13690: KAFKA-14978 ExactlyOnceWorkerSourceTask should remove parent metrics
Posted by "viktorsomogyi (via GitHub)" <gi...@apache.org>.
viktorsomogyi commented on PR #13690:
URL: https://github.com/apache/kafka/pull/13690#issuecomment-1542434744
@C0urante thanks. I'll cherry-pick it to 3.3 soon and open a PR. Btw does Kafka have an automated way or do you usually do it manually by git cherry-pick and creating PR either via git or gh?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org