You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2022/04/15 16:35:34 UTC

[GitHub] [commons-net] arturobernalg opened a new pull request, #105: Minor improvements:

arturobernalg opened a new pull request, #105:
URL: https://github.com/apache/commons-net/pull/105

   * Use contains method.
   * Avoid unnecessary boxing
   * Avoid unnecessary unboxing
   * Use Long.compare


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-net] sebbASF commented on pull request #105: Minor improvements:

Posted by GitBox <gi...@apache.org>.

sebbASF commented on PR #105:
URL: https://github.com/apache/commons-net/pull/105#issuecomment-1100440776

   AIUI Formatter.format requires Object parameters, so changing from Long.valueOf(long) to long just hides the boxing that must happen. Likewise for HashMap entries.
   
   The code generally uses explicit boxing and unboxing. This shows where it may be possible to improve data storage types to reduce conversions.
   
   Please remove the boxing changes from this PR


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-net] arturobernalg commented on pull request #105: Minor improvements:

Posted by GitBox <gi...@apache.org>.

arturobernalg commented on PR #105:
URL: https://github.com/apache/commons-net/pull/105#issuecomment-1115262883

   > @arturobernalg
   > See my previous comment.
   
   HI @garydgregory 
   Reverted.
   TY


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-net] garydgregory merged pull request #105: Minor improvements:

Posted by GitBox <gi...@apache.org>.

garydgregory merged PR #105:
URL: https://github.com/apache/commons-net/pull/105


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org