You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Simone Tripodi (Updated) (JIRA)" <ji...@apache.org> on 2012/02/10 23:06:59 UTC

[jira] [Updated] (CHAIN-58) Update Chain Context interface to use K,V generics

     [ https://issues.apache.org/jira/browse/CHAIN-58?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Simone Tripodi updated CHAIN-58:
--------------------------------

    Attachment: CHAIN-58-working-context-generics.patch

The latest attached patch implements {{Chains}} taking in consideration any {{Map<K, V>}} extension as context (including the existing {{Context}}).

All tests pass.

There are unchecked casts in the XML rules, but, IIRC, XML rules are something we want to get rid of in 2.0.

There are also binary breakages, sounds it is the right moment to bump to major version.

Please review the patch, if there is an agreement I can commit it and moving [chains] development forward. 
                
> Update Chain Context interface to use K,V generics
> --------------------------------------------------
>
>                 Key: CHAIN-58
>                 URL: https://issues.apache.org/jira/browse/CHAIN-58
>             Project: Commons Chain
>          Issue Type: Improvement
>    Affects Versions: 2.0
>            Reporter: Elijah Zupancic
>             Fix For: 2.0
>
>         Attachments: CHAIN-58-working-context-generics.patch, chain-58-improved-context-generic.diff, chain-58-with-context-generic.diff, chain-58.diff
>
>
> As discussed in the mailing list, I am suggesting that we change the definition of Context from:
> {noformat}
> public interface Context extends Map<String, Object> {
> {noformat}
> to:
> {noformat}
> public interface Context<K, V> extends Map<K, V> {
> {noformat}

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira