[GitHub] [gobblin] Will-Lo commented on a diff in pull request #3612: [GOBBLIN-1752] Fix race condition where FSTemplateCatalog would update at the same t…

[GitBox <gi...@apache.org>]

Will-Lo commented on code in PR #3612:
URL: https://github.com/apache/gobblin/pull/3612#discussion_r1041369875


##########
gobblin-service/src/test/java/org/apache/gobblin/service/monitoring/FsFlowGraphMonitorTest.java:
##########
@@ -227,6 +234,22 @@ public void testSharedFlowgraphHelper() throws Exception {
   }
 
   @Test (dependsOnMethods = "testSharedFlowgraphHelper")

Review Comment:
   It's testing that FSFlowGraphMonitor will reload the flowgraph even when there are only changes done to the flow templates, I added some comments to clarify this in the test.
   
   Previously FSFlowGraphMonitor wouldn't listen to the templateCatalog, and would only concern itself on changes made to the flowgraph.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org