You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Benjamin Hindman <be...@berkeley.edu> on 2014/01/25 01:43:17 UTC
Review Request 17343: Exposed coordinator demotion.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17343/
-----------------------------------------------------------
Review request for mesos and Jie Yu.
Repository: mesos-git
Description
-------
See summary
Diffs
-----
src/log/coordinator.hpp 35b68e938c5f2ca76bbdf8dbb0184ef1686d94f1
src/log/coordinator.cpp bc85e668a01d60077fdd954139d60edd295ad3b0
src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
src/state/zookeeper.hpp d1d1fedf27987aeaf9fbdee678d3b3848d05620a
src/tests/log_tests.cpp e493af4f2f2435efe168d07acd267b61afd37fe4
Diff: https://reviews.apache.org/r/17343/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman
Re: Review Request 17343: Exposed coordinator demotion.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17343/#review32782
-----------------------------------------------------------
Ship it!
src/log/coordinator.hpp
<https://reviews.apache.org/r/17343/#comment61750>
Please add some comments about when None() will be returned.
src/log/coordinator.hpp
<https://reviews.apache.org/r/17343/#comment61751>
Ditto here.
- Jie Yu
On Jan. 25, 2014, 12:43 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17343/
> -----------------------------------------------------------
>
> (Updated Jan. 25, 2014, 12:43 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/log/coordinator.hpp 35b68e938c5f2ca76bbdf8dbb0184ef1686d94f1
> src/log/coordinator.cpp bc85e668a01d60077fdd954139d60edd295ad3b0
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/state/zookeeper.hpp d1d1fedf27987aeaf9fbdee678d3b3848d05620a
> src/tests/log_tests.cpp e493af4f2f2435efe168d07acd267b61afd37fe4
>
> Diff: https://reviews.apache.org/r/17343/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17343: Exposed coordinator demotion.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17343/#review36350
-----------------------------------------------------------
Bad patch!
Reviews applied: [17343]
Failed command: git apply --index 17343.patch
Error:
error: patch failed: src/log/log.hpp:158
error: src/log/log.hpp: patch does not apply
error: patch failed: src/log/log.cpp:659
error: src/log/log.cpp: patch does not apply
- Mesos ReviewBot
On Feb. 19, 2014, 8:02 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17343/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:02 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/log/coordinator.hpp 35b68e938c5f2ca76bbdf8dbb0184ef1686d94f1
> src/log/coordinator.cpp daa1ca8e719798743e46cb1f7b3f1cdd569b5f6d
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/state/zookeeper.hpp d1d1fedf27987aeaf9fbdee678d3b3848d05620a
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17343/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17343: Exposed coordinator demotion.
Posted by Benjamin Hindman <be...@berkeley.edu>.
> On March 3, 2014, 10:49 p.m., Ben Mahler wrote:
> > src/tests/log_tests.cpp, line 700
> > <https://reviews.apache.org/r/17343/diff/2/?file=497560#file497560line700>
> >
> > AWAIT_READY uses a default of 10 Seconds, any reason for the explicit duration here?
AWAIT_READY used to have a lower duration and when it was increased these weren't changed. :( Alas, I added this to https://reviews.apache.org/r/18263.
- Benjamin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17343/#review36048
-----------------------------------------------------------
On Feb. 19, 2014, 8:02 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17343/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:02 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/log/coordinator.hpp 35b68e938c5f2ca76bbdf8dbb0184ef1686d94f1
> src/log/coordinator.cpp daa1ca8e719798743e46cb1f7b3f1cdd569b5f6d
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/state/zookeeper.hpp d1d1fedf27987aeaf9fbdee678d3b3848d05620a
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17343/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17343: Exposed coordinator demotion.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17343/#review36048
-----------------------------------------------------------
Ship it!
src/log/coordinator.hpp
<https://reviews.apache.org/r/17343/#comment66873>
Can you add a comment about when 'None' is returned here?
src/log/coordinator.hpp
<https://reviews.apache.org/r/17343/#comment66874>
Ditto here.
src/tests/log_tests.cpp
<https://reviews.apache.org/r/17343/#comment66875>
AWAIT_READY uses a default of 10 Seconds, any reason for the explicit duration here?
src/tests/log_tests.cpp
<https://reviews.apache.org/r/17343/#comment66876>
Ditto here and in the tests below.
- Ben Mahler
On Feb. 19, 2014, 8:02 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17343/
> -----------------------------------------------------------
>
> (Updated Feb. 19, 2014, 8:02 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary
>
>
> Diffs
> -----
>
> src/log/coordinator.hpp 35b68e938c5f2ca76bbdf8dbb0184ef1686d94f1
> src/log/coordinator.cpp daa1ca8e719798743e46cb1f7b3f1cdd569b5f6d
> src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
> src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
> src/state/zookeeper.hpp d1d1fedf27987aeaf9fbdee678d3b3848d05620a
> src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
>
> Diff: https://reviews.apache.org/r/17343/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 17343: Exposed coordinator demotion.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17343/
-----------------------------------------------------------
(Updated Feb. 19, 2014, 8:02 a.m.)
Review request for mesos and Jie Yu.
Changes
-------
Updates from review comments.
Repository: mesos-git
Description
-------
See summary
Diffs (updated)
-----
src/log/coordinator.hpp 35b68e938c5f2ca76bbdf8dbb0184ef1686d94f1
src/log/coordinator.cpp daa1ca8e719798743e46cb1f7b3f1cdd569b5f6d
src/log/log.hpp 1f0b30ddf8709cf64db7989775c8b0e926af99b5
src/log/log.cpp e83f822af86a2389e2b1abab9489713cb59838c2
src/state/zookeeper.hpp d1d1fedf27987aeaf9fbdee678d3b3848d05620a
src/tests/log_tests.cpp 7e6dbdee0a9b316e49fda5fd36a9f76331265a24
Diff: https://reviews.apache.org/r/17343/diff/
Testing
-------
make check
Thanks,
Benjamin Hindman