You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Lav Jain <lj...@pivotal.io> on 2016/01/28 23:30:35 UTC
Review Request 42923: Run a service check on PXF service for Hive
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42923/
-----------------------------------------------------------
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
Bugs: AMBARI-14816
https://issues.apache.org/jira/browse/AMBARI-14816
Repository: ambari
Description
-------
End user should be able to run a Service Check from the Action menu via Ambari so that they can quickly confirm whether the PXF service is working functionally with Hive or not.
Diffs
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py 36dc7c1
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py 3138379
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 72b59e4
Diff: https://reviews.apache.org/r/42923/diff/
Testing
-------
Service check for PXF tested manually.
Thanks,
Lav Jain
Re: Review Request 42923: Run a service check on PXF service for Hive
Posted by Lav Jain <lj...@pivotal.io>.
> On Jan. 29, 2016, 2:29 a.m., Alexander Denissov wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py, line 266
> > <https://reviews.apache.org/r/42923/diff/1/?file=1225186#file1225186line266>
> >
> > what if cleanup before failed ? You can add IF NOT EXISTS to make sure it doesn't error out.
Will remove the cleanup before (to save on unnecessary call as we also do cleanup after) and add IF NOT EXISTS clause here.
- Lav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42923/#review116876
-----------------------------------------------------------
On Jan. 28, 2016, 10:30 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42923/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 10:30 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14816
> https://issues.apache.org/jira/browse/AMBARI-14816
>
>
> Repository: ambari
>
>
> Description
> -------
>
> End user should be able to run a Service Check from the Action menu via Ambari so that they can quickly confirm whether the PXF service is working functionally with Hive or not.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py 36dc7c1
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py 3138379
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 72b59e4
>
> Diff: https://reviews.apache.org/r/42923/diff/
>
>
> Testing
> -------
>
> Service check for PXF tested manually.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 42923: Run a service check on PXF service for Hive
Posted by Alexander Denissov <ad...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42923/#review116876
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py (line 264)
<https://reviews.apache.org/r/42923/#comment177973>
what if cleanup before failed ? You can add IF NOT EXISTS to make sure it doesn't error out.
- Alexander Denissov
On Jan. 28, 2016, 10:30 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42923/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 10:30 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14816
> https://issues.apache.org/jira/browse/AMBARI-14816
>
>
> Repository: ambari
>
>
> Description
> -------
>
> End user should be able to run a Service Check from the Action menu via Ambari so that they can quickly confirm whether the PXF service is working functionally with Hive or not.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py 36dc7c1
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py 3138379
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 72b59e4
>
> Diff: https://reviews.apache.org/r/42923/diff/
>
>
> Testing
> -------
>
> Service check for PXF tested manually.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 42923: Run a service check on PXF service for Hive
Posted by Lav Jain <lj...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42923/
-----------------------------------------------------------
(Updated Jan. 29, 2016, 11:41 p.m.)
Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
Changes
-------
Create HIVE table if not exists
Bugs: AMBARI-14816
https://issues.apache.org/jira/browse/AMBARI-14816
Repository: ambari
Description
-------
End user should be able to run a Service Check from the Action menu via Ambari so that they can quickly confirm whether the PXF service is working functionally with Hive or not.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py 36dc7c1
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py 3138379
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 72b59e4
Diff: https://reviews.apache.org/r/42923/diff/
Testing
-------
Service check for PXF tested manually.
Thanks,
Lav Jain
Re: Review Request 42923: Run a service check on PXF service for Hive
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42923/#review116904
-----------------------------------------------------------
Ship it!
Ship It!
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py (line 306)
<https://reviews.apache.org/r/42923/#comment177996>
Nice catch
- Matt
On Jan. 28, 2016, 2:30 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42923/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 2:30 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14816
> https://issues.apache.org/jira/browse/AMBARI-14816
>
>
> Repository: ambari
>
>
> Description
> -------
>
> End user should be able to run a Service Check from the Action menu via Ambari so that they can quickly confirm whether the PXF service is working functionally with Hive or not.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py 36dc7c1
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py 3138379
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 72b59e4
>
> Diff: https://reviews.apache.org/r/42923/diff/
>
>
> Testing
> -------
>
> Service check for PXF tested manually.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 42923: Run a service check on PXF service for Hive
Posted by Lav Jain <lj...@pivotal.io>.
> On Jan. 29, 2016, 5:15 a.m., Matt wrote:
> > ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py, line 58
> > <https://reviews.apache.org/r/42923/diff/1/?file=1225186#file1225186line58>
> >
> > Would this fail if Hive is installed, but Hive is in stopped state?
> >
> > Same for Hbase above?
It will fail if Hive is installed but not running. It is a valid test that PXF service check for hive will fail.
- Lav
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42923/#review116906
-----------------------------------------------------------
On Jan. 28, 2016, 10:30 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42923/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 10:30 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14816
> https://issues.apache.org/jira/browse/AMBARI-14816
>
>
> Repository: ambari
>
>
> Description
> -------
>
> End user should be able to run a Service Check from the Action menu via Ambari so that they can quickly confirm whether the PXF service is working functionally with Hive or not.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py 36dc7c1
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py 3138379
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 72b59e4
>
> Diff: https://reviews.apache.org/r/42923/diff/
>
>
> Testing
> -------
>
> Service check for PXF tested manually.
>
>
> Thanks,
>
> Lav Jain
>
>
Re: Review Request 42923: Run a service check on PXF service for Hive
Posted by Matt <mi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42923/#review116906
-----------------------------------------------------------
ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py (line 56)
<https://reviews.apache.org/r/42923/#comment177998>
Would this fail if Hive is installed, but Hive is in stopped state?
Same for Hbase above?
- Matt
On Jan. 28, 2016, 2:30 p.m., Lav Jain wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42923/
> -----------------------------------------------------------
>
> (Updated Jan. 28, 2016, 2:30 p.m.)
>
>
> Review request for Ambari, Alexander Denissov, Alejandro Fernandez, bhuvnesh chaudhary, jun aoki, Jayush Luniya, Matt, Newton Alex, and Oleksandr Diachenko.
>
>
> Bugs: AMBARI-14816
> https://issues.apache.org/jira/browse/AMBARI-14816
>
>
> Repository: ambari
>
>
> Description
> -------
>
> End user should be able to run a Service Check from the Action menu via Ambari so that they can quickly confirm whether the PXF service is working functionally with Hive or not.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/params.py 36dc7c1
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/pxf_constants.py 3138379
> ambari-server/src/main/resources/common-services/PXF/3.0.0/package/scripts/service_check.py 72b59e4
>
> Diff: https://reviews.apache.org/r/42923/diff/
>
>
> Testing
> -------
>
> Service check for PXF tested manually.
>
>
> Thanks,
>
> Lav Jain
>
>