You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by Jesse Glick <jg...@cloudbees.com> on 2013/03/08 15:48:15 UTC
Contributions (was: Re: Suggestion - JUnit4 tests for Ant)
First, BuildFileRule sounds like a great idea; do not see a patch so cannot comment further.
Second, should Michael just be nominated as a committer? The @Ignore change was complex and valuable, and refactoring unit tests demonstrates serious intent.
Third, why are we still using Subversion when we could be using Git [1]? Apache makes us keep the “official” repo on git.apache.org. That is lame, especially given the
existence of CLAHub [2]; but with Git you can still do your real work on GitHub, whose crown jewel is of course the pull request system. PRs make it much, much easier to
evaluate, comment on, iterate, and accept contributions than patches attached to Bugzilla—and make the distinction between “committer” and “frequent contributor” only a
matter of whether you have the permission to click the “Merge” button at the end.
That said, Antoine is doing most of the work these days so whatever environment he is most comfortable in wins. Just thought I would put out a probe.
[1] http://www.apache.org/dev/writable-git
[2] http://www.clahub.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Contributions (was: Re: Suggestion - JUnit4 tests for Ant)
Posted by Michael Clarke <mi...@gmail.com>.
I'm not sure why my patch didn't make it onto the list so I've cloned the
Ant Github repository to my account [1] and applied my example changes [2].
I'll leave the discussion around Git versus Subversion for others to debate
(Git would get my vote for what it's worth). I'm happy to either contribute
my unit testing changes as a patch (although this could get very complex to
review given the number of tests available for change) or to commit changes
myself if the project wants me on-board as a committer.
Either way, feel free to comment on my changes either directly in Github or
on email. The only impact my changes should have on external code would be
compile failures for anyone extending an existing tests and expecting to
have methods like JUnit3's TestCase#assert...() or anything other than a
no-args constructor still available; or users having tests not running
since they're not marked with @Test and no longer implicitly extends
TestCase. I would expect such situations are limited and can be covered in
a release note, as well as leaving the current BuildFileTest in place (but
deprecated) for anyone who doesn't want to migrate fully.
Thanks,
Michael
[1] https://github.com/mc1arke/ant
[2]
https://github.com/mc1arke/ant/commit/a04fd9ad0cec576b55a119d2e846329a3ae36e91
On 8 March 2013 14:48, Jesse Glick <jg...@cloudbees.com> wrote:
> First, BuildFileRule sounds like a great idea; do not see a patch so
> cannot comment further.
> Second, should Michael just be nominated as a committer? The @Ignore
> change was complex and valuable, and refactoring unit tests demonstrates
> serious intent.
>
> Third, why are we still using Subversion when we could be using Git [1]?
> Apache makes us keep the “official” repo on git.apache.org. That is lame,
> especially given the existence of CLAHub [2]; but with Git you can still do
> your real work on GitHub, whose crown jewel is of course the pull request
> system. PRs make it much, much easier to evaluate, comment on, iterate, and
> accept contributions than patches attached to Bugzilla—and make the
> distinction between “committer” and “frequent contributor” only a matter of
> whether you have the permission to click the “Merge” button at the end.
>
> That said, Antoine is doing most of the work these days so whatever
> environment he is most comfortable in wins. Just thought I would put out a
> probe.
>
>
> [1] http://www.apache.org/dev/**writable-git<http://www.apache.org/dev/writable-git>
> [2] http://www.clahub.com/
>
>
> ------------------------------**------------------------------**---------
> To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
> For additional commands, e-mail: dev-help@ant.apache.org
>
>
AW: Contributions
Posted by "Jan Matèrne (jhm)" <ap...@materne.de>.
> > Third, why are we still using Subversion when we could be using Git
> > [1]?
>
> Because we never talked about moving, I guess. :-)
Yes, I think that's the reason.
Another point could be, that each contributor could use git-svn for accessing the official repository.
It's not "the full Git power", but you have your "preferred" tool.
> > Apache makes us keep the “official” repo on git.apache.org. That is
> > lame, especially given the existence of CLAHub [2];
>
> I disagree, I also think the authoritative source of Apache software
> should be on systems maintained by the ASF.
+1.
Having one official repo, where you could rely on its IP-integrity is a big benefit, I think.
> You can have the power of pull requests even when the authoritative
> source is the ASF repo, the only thing you lack is the "merge" button
> in the UI - but this really doesn't do anything you couldn't do with
> the command line. Pull from the branch that makes up the PR and push
> it to the ASF repo. I've even been told the Github PR system will
> recognize the branch has been merged and close the PR as soon as the
> github mirror catches up - but I haven't tried it so far.
If we move to Git, we could tune the workflow here and test the possibilities ;)
Jan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
Re: Contributions
Posted by Stefan Bodewig <bo...@apache.org>.
On 2013-03-08, Jesse Glick wrote:
> Third, why are we still using Subversion when we could be using Git
> [1]?
Because we never talked about moving, I guess. :-)
> Apache makes us keep the “official” repo on git.apache.org. That is
> lame, especially given the existence of CLAHub [2];
I disagree, I also think the authoritative source of Apache software
should be on systems maintained by the ASF.
As for CLAHub, I pretty much doubt a click on a "I agree" button on a
random web page is even close to a signed piece of paper when courts
have to decide in legal conflicts. That's just my personal opinion, of
course.
You can have the power of pull requests even when the authoritative
source is the ASF repo, the only thing you lack is the "merge" button in
the UI - but this really doesn't do anything you couldn't do with the
command line. Pull from the branch that makes up the PR and push it to
the ASF repo. I've even been told the Github PR system will recognize
the branch has been merged and close the PR as soon as the github mirror
catches up - but I haven't tried it so far.
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org