[GitHub] [hive] SourabhBadhya commented on a diff in pull request #3746: HIVE-26716: Query based Rebalance compaction on full acid tables

[GitBox <gi...@apache.org>]

SourabhBadhya commented on code in PR #3746:
URL: https://github.com/apache/hive/pull/3746#discussion_r1021327481


##########
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java:
##########
@@ -1052,8 +1053,15 @@ public void process(Object row, int tag) throws HiveException {
           createNewPaths(null, lbDirName);
         }
       } else if (conf.isCompactionTable()) {
-        int bucketProperty = getBucketProperty(row);
-        bucketId = BucketCodec.determineVersion(bucketProperty).decodeWriterId(bucketProperty);
+        if (conf.isRebalanceCompactionTable()) {
+          //For rebalacning compaction, the unencoded bucket id comes in the bucketproperty. It must be encoded before

Review Comment:
   nit: Typo



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org