You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by tu...@apache.org on 2023/04/01 07:21:50 UTC

[shardingsphere] branch master updated: Remove useless filed of YamlDynamicReadwriteSplittingStrategyConfiguration (#24938)

This is an automated email from the ASF dual-hosted git repository.

tuichenchuxin pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git


The following commit(s) were added to refs/heads/master by this push:
     new edbdd263ef9 Remove useless filed of YamlDynamicReadwriteSplittingStrategyConfiguration (#24938)
edbdd263ef9 is described below

commit edbdd263ef972071e1657100802561850060811a
Author: Liang Zhang <zh...@apache.org>
AuthorDate: Sat Apr 1 15:21:43 2023 +0800

    Remove useless filed of YamlDynamicReadwriteSplittingStrategyConfiguration (#24938)
---
 RELEASE-NOTES.md                                                      | 1 -
 ...e_5.2.0_is_Released,_Bringing_New_Cloud_Native_Possibilities.en.md | 2 --
 .../shardingsphere-jdbc/java-api/rules/readwrite-splitting.cn.md      | 1 -
 .../shardingsphere-jdbc/java-api/rules/readwrite-splitting.en.md      | 1 -
 .../strategy/YamlDynamicReadwriteSplittingStrategyConfiguration.java  | 2 --
 .../src/main/antlr4/imports/readwrite-splitting/RDLStatement.g4       | 4 ----
 6 files changed, 11 deletions(-)

diff --git a/RELEASE-NOTES.md b/RELEASE-NOTES.md
index 67e9cc037b5..abfeac3adf4 100644
--- a/RELEASE-NOTES.md
+++ b/RELEASE-NOTES.md
@@ -391,7 +391,6 @@
 1. DistSQL: Improve the result of `EXPORT DATABASE CONFIG`
 1. DistSQL: Support more databases for `FORMAT SQL`
 1. DistSQL: Optimize the execution logic of `CREATE TRAFFIC RULE`
-1. DistSQL: Add paramter `writeDataSourceQueryEnabled` for RDL READWRITE_SPLITTING RULE.
 1. DistSQL: Support `assistEncryptor` for Encrypt RDL
 1. DistSQL: Add sharding algorithm type check when `CREATE SHARDING TABLE RULE`
 1. Support database discovery to configure multiple groups of high availability under the same logic database
diff --git a/docs/blog/content/material/2022_09_08_Apache_ShardingSphere_5.2.0_is_Released,_Bringing_New_Cloud_Native_Possibilities.en.md b/docs/blog/content/material/2022_09_08_Apache_ShardingSphere_5.2.0_is_Released,_Bringing_New_Cloud_Native_Possibilities.en.md
index ffb8087fa7c..79bfa7daf22 100644
--- a/docs/blog/content/material/2022_09_08_Apache_ShardingSphere_5.2.0_is_Released,_Bringing_New_Cloud_Native_Possibilities.en.md
+++ b/docs/blog/content/material/2022_09_08_Apache_ShardingSphere_5.2.0_is_Released,_Bringing_New_Cloud_Native_Possibilities.en.md
@@ -356,8 +356,6 @@ Below are all the update logs of ShardingSphere 5.2.0. To deliver a better user
 
 - DistSQL: Optimize the execution logic of CREATE TRAFFIC RULE
 
-- DistSQL: Add paramter writeDataSourceQueryEnabled for RDL READWRITE_SPLITTING RULE.
-
 - DistSQL: Support assistEncryptor for Encrypt RDL
 
 - DistSQL: Add sharding algorithm type check when CREATE SHARDING TABLE RULE
diff --git a/docs/document/content/user-manual/shardingsphere-jdbc/java-api/rules/readwrite-splitting.cn.md b/docs/document/content/user-manual/shardingsphere-jdbc/java-api/rules/readwrite-splitting.cn.md
index 4285a2391cf..15a750ba63a 100644
--- a/docs/document/content/user-manual/shardingsphere-jdbc/java-api/rules/readwrite-splitting.cn.md
+++ b/docs/document/content/user-manual/shardingsphere-jdbc/java-api/rules/readwrite-splitting.cn.md
@@ -50,7 +50,6 @@ Java API 形式配置的读写分离可以方便的适用于各种场景,不
 | *名称*                            | *数据类型* | *说明*             | *默认值* |
 |---------------------------------|--------|------------------|-------|
 | autoAwareDataSourceName         | String | 数据库发现的逻辑数据源名称    | -     |
-| writeDataSourceQueryEnabled (?) | String | 读库全部下线,主库是否承担读流量 | true  |
 
 算法类型的详情,请参见[内置负载均衡算法列表](/cn/user-manual/common-config/builtin-algorithm/load-balance)。
 查询一致性路由的详情,请参见[核心特性:读写分离](/cn/features/readwrite-splitting/)。
diff --git a/docs/document/content/user-manual/shardingsphere-jdbc/java-api/rules/readwrite-splitting.en.md b/docs/document/content/user-manual/shardingsphere-jdbc/java-api/rules/readwrite-splitting.en.md
index 22d21966cea..931cdfeaaf1 100644
--- a/docs/document/content/user-manual/shardingsphere-jdbc/java-api/rules/readwrite-splitting.en.md
+++ b/docs/document/content/user-manual/shardingsphere-jdbc/java-api/rules/readwrite-splitting.en.md
@@ -50,7 +50,6 @@ Configurable Properties:
 | *Name*                          | *DataType* | *Description*                                                                                               | *Default Value* |
 |---------------------------------|------------|-------------------------------------------------------------------------------------------------------------|-----------------|
 | autoAwareDataSourceName         | String     | Database discovery logic data source name                                                                   | -               |
-| writeDataSourceQueryEnabled (?) | String     | All read data source are offline, write data source whether the data source is responsible for read traffic | true            |
 
 Please refer to [Built-in Load Balance Algorithm List](/en/user-manual/common-config/builtin-algorithm/load-balance) for details on algorithm types.
 Please refer to [Read-write splitting-Core features](/en/features/readwrite-splitting/) for more details about query consistent routing.
diff --git a/features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/yaml/config/strategy/YamlDynamicReadwriteSplittingStrategyConfiguration.java b/features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/yaml/config/strategy/YamlDynamicReadwriteSplittingStrategyConfiguration.java
index df4543347e8..c8ed16c22e4 100644
--- a/features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/yaml/config/strategy/YamlDynamicReadwriteSplittingStrategyConfiguration.java
+++ b/features/readwrite-splitting/core/src/main/java/org/apache/shardingsphere/readwritesplitting/yaml/config/strategy/YamlDynamicReadwriteSplittingStrategyConfiguration.java
@@ -29,6 +29,4 @@ import org.apache.shardingsphere.infra.util.yaml.YamlConfiguration;
 public final class YamlDynamicReadwriteSplittingStrategyConfiguration implements YamlConfiguration {
     
     private String autoAwareDataSourceName;
-    
-    private String writeDataSourceQueryEnabled;
 }
diff --git a/features/readwrite-splitting/distsql/parser/src/main/antlr4/imports/readwrite-splitting/RDLStatement.g4 b/features/readwrite-splitting/distsql/parser/src/main/antlr4/imports/readwrite-splitting/RDLStatement.g4
index 8225b96a078..d9263bdf531 100644
--- a/features/readwrite-splitting/distsql/parser/src/main/antlr4/imports/readwrite-splitting/RDLStatement.g4
+++ b/features/readwrite-splitting/distsql/parser/src/main/antlr4/imports/readwrite-splitting/RDLStatement.g4
@@ -59,10 +59,6 @@ ifExists
     : IF EXISTS
     ;
 
-writeDataSourceQueryEnabled
-    : TRUE | FALSE
-    ;
-
 ifNotExists
     : IF NOT EXISTS
     ;