You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/13 20:40:05 UTC
[GitHub] [arrow] pachamaltese opened a new pull request #10020: 1st draft 12370
pachamaltese opened a new pull request #10020:
URL: https://github.com/apache/arrow/pull/10020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a change in pull request #10020: ARROW-12370: [R] Bindings for power kernel
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on a change in pull request #10020:
URL: https://github.com/apache/arrow/pull/10020#discussion_r613651376
##########
File path: r/tests/testthat/test-dplyr-filter.R
##########
@@ -284,7 +300,7 @@ test_that("filter environment scope", {
# Also for functions
# 'could not find function "isEqualTo"' because we haven't defined it yet
expect_dplyr_error(input %>% filter(isEqualTo(int, 4)), tbl)
-
+
Review comment:
```suggestion
```
##########
File path: r/tests/testthat/test-dplyr-filter.R
##########
@@ -399,5 +415,5 @@ test_that("filter() with .data pronoun", {
collect(),
tbl
)
-
+
Review comment:
```suggestion
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachamaltese commented on pull request #10020: ARROW-12370: [R] Bindings for power kernel
Posted by GitBox <gi...@apache.org>.
pachamaltese commented on pull request #10020:
URL: https://github.com/apache/arrow/pull/10020#issuecomment-819575897
> Looks good. Should we also add a test of calling it through `dplyr`, just to be sure/explicit? (The answer may be no.)
>
> Should we test with other data types as well? Not that we need R tests for this, but just to confirm that the C++ implementation is doing what it should with types other than float64?
sure ! adding now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10020: ARROW-12370: [R] Bindings for power kernel
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10020:
URL: https://github.com/apache/arrow/pull/10020#issuecomment-819769212
https://issues.apache.org/jira/browse/ARROW-12370
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pachamaltese commented on pull request #10020: ARROW-12370: [R] Bindings for power kernel
Posted by GitBox <gi...@apache.org>.
pachamaltese commented on pull request #10020:
URL: https://github.com/apache/arrow/pull/10020#issuecomment-819638117
> this
the only part I don't understand is a dplyr test here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10020: 1st draft 12370
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10020:
URL: https://github.com/apache/arrow/pull/10020#issuecomment-819241014
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
If this is not a [minor PR](https://github.com/apache/arrow/blob/master/CONTRIBUTING.md#Minor-Fixes). Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW
Opening JIRAs ahead of time contributes to the [Openness](http://theapacheway.com/open/#:~:text=Openness%20allows%20new%20users%20the,must%20happen%20in%20the%20open.) of the Apache Arrow project.
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
or
MINOR: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson closed pull request #10020: ARROW-12370: [R] Bindings for power kernel
Posted by GitBox <gi...@apache.org>.
nealrichardson closed pull request #10020:
URL: https://github.com/apache/arrow/pull/10020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org