You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hbase.apache.org by zh...@apache.org on 2018/06/26 06:27:51 UTC
[15/48] hbase git commit: HBASE-20770 WAL cleaner logs way too much;
gets clogged when lots of work to do
HBASE-20770 WAL cleaner logs way too much; gets clogged when lots of work to do
General log cleanup; setting stuff that can flood the log to TRACE.
Project: http://git-wip-us.apache.org/repos/asf/hbase/repo
Commit: http://git-wip-us.apache.org/repos/asf/hbase/commit/0db2b628
Tree: http://git-wip-us.apache.org/repos/asf/hbase/tree/0db2b628
Diff: http://git-wip-us.apache.org/repos/asf/hbase/diff/0db2b628
Branch: refs/heads/HBASE-19064
Commit: 0db2b628d6db90b5ad300773d81e9cdb7dd0ebcd
Parents: 025ddce
Author: Michael Stack <st...@apache.org>
Authored: Sat Jun 23 23:29:11 2018 -0700
Committer: Michael Stack <st...@apache.org>
Committed: Mon Jun 25 12:13:04 2018 -0700
----------------------------------------------------------------------
.../hbase/security/NettyHBaseSaslRpcClient.java | 5 +----
.../security/NettyHBaseSaslRpcClientHandler.java | 8 ++------
.../hbase/master/assignment/AssignProcedure.java | 7 +++++--
.../hbase/master/balancer/RegionLocationFinder.java | 6 ++----
.../hadoop/hbase/master/cleaner/CleanerChore.java | 14 ++++----------
.../hadoop/hbase/master/cleaner/HFileCleaner.java | 6 +++---
6 files changed, 17 insertions(+), 29 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/hbase/blob/0db2b628/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClient.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClient.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClient.java
index a4ddd62..6771e32 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClient.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClient.java
@@ -45,10 +45,7 @@ public class NettyHBaseSaslRpcClient extends AbstractHBaseSaslRpcClient {
public void setupSaslHandler(ChannelPipeline p) {
String qop = (String) saslClient.getNegotiatedProperty(Sasl.QOP);
- if (LOG.isDebugEnabled()) {
- LOG.debug("SASL client context established. Negotiated QoP: " + qop);
- }
-
+ LOG.trace("SASL client context established. Negotiated QoP {}", qop);
if (qop == null || "auth".equalsIgnoreCase(qop)) {
return;
}
http://git-wip-us.apache.org/repos/asf/hbase/blob/0db2b628/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
----------------------------------------------------------------------
diff --git a/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java b/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
index afc15ab..8da3fde 100644
--- a/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
+++ b/hbase-client/src/main/java/org/apache/hadoop/hbase/security/NettyHBaseSaslRpcClientHandler.java
@@ -71,9 +71,7 @@ public class NettyHBaseSaslRpcClientHandler extends SimpleChannelInboundHandler<
}
private void writeResponse(ChannelHandlerContext ctx, byte[] response) {
- if (LOG.isDebugEnabled()) {
- LOG.debug("Will send token of size " + response.length + " from initSASLContext.");
- }
+ LOG.trace("Sending token size={} from initSASLContext.", response.length);
ctx.writeAndFlush(
ctx.alloc().buffer(4 + response.length).writeInt(response.length).writeBytes(response));
}
@@ -133,9 +131,7 @@ public class NettyHBaseSaslRpcClientHandler extends SimpleChannelInboundHandler<
}
return;
}
- if (LOG.isDebugEnabled()) {
- LOG.debug("Will read input token of size " + len + " for processing by initSASLContext");
- }
+ LOG.trace("Reading input token size={} for processing by initSASLContext", len);
final byte[] challenge = new byte[len];
msg.readBytes(challenge);
byte[] response = ugi.doAs(new PrivilegedExceptionAction<byte[]>() {
http://git-wip-us.apache.org/repos/asf/hbase/blob/0db2b628/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java
index 768f32b..86f0a3f 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/assignment/AssignProcedure.java
@@ -291,8 +291,11 @@ public class AssignProcedure extends RegionTransitionProcedure {
" transition openSeqNum=" + openSeqNum + ", " + regionNode);
}
if (openSeqNum < regionNode.getOpenSeqNum()) {
- LOG.warn("Skipping update of open seqnum with " + openSeqNum +
- " because current seqnum=" + regionNode.getOpenSeqNum());
+ // Don't bother logging if openSeqNum == 0
+ if (openSeqNum != 0) {
+ LOG.warn("Skipping update of open seqnum with " + openSeqNum +
+ " because current seqnum=" + regionNode.getOpenSeqNum());
+ }
} else {
regionNode.setOpenSeqNum(openSeqNum);
}
http://git-wip-us.apache.org/repos/asf/hbase/blob/0db2b628/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionLocationFinder.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionLocationFinder.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionLocationFinder.java
index 07e9600..fb7731f 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionLocationFinder.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/RegionLocationFinder.java
@@ -220,8 +220,7 @@ class RegionLocationFinder {
tableDescriptor = this.services.getTableDescriptors().get(tableName);
}
} catch (FileNotFoundException fnfe) {
- LOG.debug("FileNotFoundException during getTableDescriptors." + " Current table name = "
- + tableName, fnfe);
+ LOG.debug("tableName={}", tableName, fnfe);
}
return tableDescriptor;
@@ -277,8 +276,7 @@ class RegionLocationFinder {
blockDistbn = cache.get(hri);
return blockDistbn;
} else {
- LOG.debug("HDFSBlocksDistribution not found in cache for region "
- + hri.getRegionNameAsString());
+ LOG.trace("HDFSBlocksDistribution not found in cache for {}", hri.getRegionNameAsString());
blockDistbn = internalGetTopBlockLocation(hri);
cache.put(hri, blockDistbn);
return blockDistbn;
http://git-wip-us.apache.org/repos/asf/hbase/blob/0db2b628/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
index bcb23ac..cb202c8 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/CleanerChore.java
@@ -272,13 +272,9 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
try {
POOL.latchCountUp();
if (runCleaner()) {
- if (LOG.isTraceEnabled()) {
- LOG.trace("Cleaned all WALs under {}", oldFileDir);
- }
+ LOG.trace("Cleaned all WALs under {}", oldFileDir);
} else {
- if (LOG.isTraceEnabled()) {
- LOG.trace("WALs outstanding under {}", oldFileDir);
- }
+ LOG.trace("WALs outstanding under {}", oldFileDir);
}
} finally {
POOL.latchCountDown();
@@ -291,9 +287,7 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
POOL.updatePool((long) (0.8 * getTimeUnit().toMillis(getPeriod())));
}
} else {
- if (LOG.isTraceEnabled()) {
- LOG.trace("Cleaner chore disabled! Not cleaning.");
- }
+ LOG.trace("Cleaner chore disabled! Not cleaning.");
}
}
@@ -472,7 +466,7 @@ public abstract class CleanerChore<T extends FileCleanerDelegate> extends Schedu
@Override
protected Boolean compute() {
- LOG.debug("Cleaning under {}", dir);
+ LOG.trace("Cleaning under {}", dir);
List<FileStatus> subDirs;
List<FileStatus> files;
try {
http://git-wip-us.apache.org/repos/asf/hbase/blob/0db2b628/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java
----------------------------------------------------------------------
diff --git a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java
index b85b569..a5e87ae 100644
--- a/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java
+++ b/hbase-server/src/main/java/org/apache/hadoop/hbase/master/cleaner/HFileCleaner.java
@@ -235,7 +235,7 @@ public class HFileCleaner extends CleanerChore<BaseHFileCleanerDelegate> {
break;
}
if (task != null) {
- LOG.debug("Removing {}", task.filePath);
+ LOG.trace("Removing {}", task.filePath);
boolean succeed;
try {
succeed = this.fs.delete(task.filePath, false);
@@ -258,13 +258,13 @@ public class HFileCleaner extends CleanerChore<BaseHFileCleanerDelegate> {
private void countDeletedFiles(boolean isLargeFile, boolean fromLargeQueue) {
if (isLargeFile) {
if (deletedLargeFiles.get() == Long.MAX_VALUE) {
- LOG.info("Deleted more than Long.MAX_VALUE large files, reset counter to 0");
+ LOG.debug("Deleted more than Long.MAX_VALUE large files, reset counter to 0");
deletedLargeFiles.set(0L);
}
deletedLargeFiles.incrementAndGet();
} else {
if (deletedSmallFiles.get() == Long.MAX_VALUE) {
- LOG.info("Deleted more than Long.MAX_VALUE small files, reset counter to 0");
+ LOG.debug("Deleted more than Long.MAX_VALUE small files, reset counter to 0");
deletedSmallFiles.set(0L);
}
if (fromLargeQueue) {