[GitHub] [cassandra] jonmeredith commented on issue #354: CASSANDRA-15319 against 2.2

[GitBox <gi...@apache.org>]

jonmeredith commented on issue #354: CASSANDRA-15319 against 2.2
URL: https://github.com/apache/cassandra/pull/354#issuecomment-539215659
 
 
   Thanks @ifesdjeen, I do like that the change reduces a possible source of user error of leaving gaps in the nodeId sequence, but I guard against that with an explicit runtime check.
   
   The reason I use the map approach is so that if a user wants, they can specify exactly where each node is, so they know where `cluster.coordinator(nodeId)` runs from as they specified it, rather than having to either know that nodeIds are allocated in the order added and I think that gives tests a bit more clarity as to how things are allocated when the test needs more detail than the `withXXX` calls provide (or they don't want to iterate over the nodes to find where things are).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org