You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/08/22 13:51:52 UTC
[GitHub] [dolphinscheduler] 8431 opened a new issue, #11601: [Bug] [Module Name] Bug title
8431 opened a new issue, #11601:
URL: https://github.com/apache/dolphinscheduler/issues/11601
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
`private void
createFolder( String folderName) {
if (!s3Client.doesObjectExist(BUCKET_NAME, folderName + FOLDER_SEPARATOR)) {
ObjectMetadata metadata = new ObjectMetadata();
metadata.setContentLength(0);
InputStream emptyContent = new ByteArrayInputStream(new byte[0]);
PutObjectRequest putObjectRequest = new PutObjectRequest(BUCKET_NAME, folderName + FOLDER_SEPARATOR, emptyContent, metadata);
s3Client.putObject(putObjectRequest);
}
}`
我在创建租户的时候，会调用这个方法。但是BUCKET_NAME是Constants定义死的常量
` public static final String BUCKET_NAME = "dolphinscheduler-test";
`
这将限制我必须提前创建一个BUCKET_NAME为dolphinscheduler-test的名称，才能使用s3的功能.
建议官方，讲这个变量配置话提供出来。
### What you expected to happen
这将限制我必须提前创建一个BUCKET_NAME为dolphinscheduler-test的名称，才能使用s3的功能.
建议官方，讲这个变量配置话提供出来。
### How to reproduce
按官方文档配置s3参数
### Anything else
_No response_
### Version
3.0.0
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] fuchanghai commented on issue #11601: [Bug] [Module Name] Bug title
Posted by GitBox <gi...@apache.org>.
fuchanghai commented on issue #11601:
URL: https://github.com/apache/dolphinscheduler/issues/11601#issuecomment-1223397353
Maybe hit the ```improvements``` tag instead of the ```bug``` tag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #11601: [Bug] [Resources center] bucket name error in s3 while create tenant folder
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #11601:
URL: https://github.com/apache/dolphinscheduler/issues/11601#issuecomment-1223426665
This issue has been fixed in #10433. Will be release in the next version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11601: [Bug] [Module Name] Bug title
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11601:
URL: https://github.com/apache/dolphinscheduler/issues/11601#issuecomment-1222443843
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/dolphinscheduler/issues?q=is%3Aissue) and found no similar issues.
### What happened
`private void
createFolder( String folderName ) {
if (!s3Client.doesObjectExist(BUCKET_NAME, folderName + FOLDER_SEPARATOR)) {
ObjectMetadata metadata = new ObjectMetadata();
metadata.setContentLength(0);
InputStream emptyContent = new ByteArrayInputStream(new byte[0]);
PutObjectRequest putObjectRequest = new PutObjectRequest(BUCKET_NAME, folderName + FOLDER_SEPARATOR, emptyContent, metadata);
s3Client.putObject(putObjectRequest);
}
}`
I call this method when I create a tenant. But BUCKET_NAME is a constant defined by Constants
` public static final String BUCKET_NAME = "dolphinscheduler-test";
`
This will restrict me from having to create a BUCKET_NAME with dolphinscheduler-test in advance in order to use the features of s3.
It is recommended that the official provide this variable configuration.
### What you expected to happen
This will restrict me from having to create a BUCKET_NAME with dolphinscheduler-test in advance in order to use the features of s3.
It is recommended that the official provide this variable configuration.
### How to reproduce
Configure s3 parameters according to the official documentation
### Anything else
_No response_
### Version
3.0.0
### Are you willing to submit PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] github-actions[bot] commented on issue #11601: [Bug] [Module Name] Bug title
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #11601:
URL: https://github.com/apache/dolphinscheduler/issues/11601#issuecomment-1222444138
Thank you for your feedback, we have received your issue, Please wait patiently for a reply.
* In order for us to understand your request as soon as possible, please provide detailed information、version or pictures.
* If you haven't received a reply for a long time, you can [join our slack](https://s.apache.org/dolphinscheduler-slack) and send your question to channel `#troubleshooting`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on issue #11601: [Bug] [Module Name] Bug title
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on issue #11601:
URL: https://github.com/apache/dolphinscheduler/issues/11601#issuecomment-1223405172
I'll fix it.
BTW, it's better to use english to describe it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS closed issue #11601: [Bug] [Resources center] bucket name error in s3 while create tenant folder
Posted by GitBox <gi...@apache.org>.
SbloodyS closed issue #11601: [Bug] [Resources center] bucket name error in s3 while create tenant folder
URL: https://github.com/apache/dolphinscheduler/issues/11601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org