You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/02/26 22:39:19 UTC
[GitHub] [samza] DPUkyle opened a new pull request #1295: SAMZA-2473:
gradleVersion and wrapper jar are out-of-sync
DPUkyle opened a new pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295
Update Gradle wrapper to 5.2.1
- Fix built-in wrapper task to read value from gradle.properties
- Commit new wrapper scripts and bootstrap jar
- `$ ./gradlew wrapper` to update in the future
- Fix maven publish behavior change; see https://docs.gradle.org/5.2.1/userguide/publishing_maven.html#publishing_maven:deferred_configuration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] DPUkyle commented on issue #1295: SAMZA-2473: gradleVersion
and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
DPUkyle commented on issue #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#issuecomment-594082893
I think this is ready to go, pending CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] DPUkyle commented on a change in pull request #1295:
SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
DPUkyle commented on a change in pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r386760084
##########
File path: build.gradle
##########
@@ -866,3 +866,8 @@ project(":samza-test_$scalaSuffix") {
from(configurations.archives.artifacts.files) { into("lib/") }
}
}
+
+// SAMZA-2473 read wrapper version from gradle.properties
+wrapper {
+ gradleVersion = project.gradleVersion
Review comment:
Great suggestion; will do.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] cameronlee314 commented on issue #1295: SAMZA-2473:
gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
cameronlee314 commented on issue #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#issuecomment-593722932
One other thing: Could you please update your pull request description to follow the guidelines at https://cwiki.apache.org/confluence/display/SAMZA/SEP-25%3A+PR+Title+And+Description+Guidelines? It helps us track open source changes.
You shouldn't need to add much more detail than what you already have, but it would be great if you could categorize your bullet points into the corresponding sections listed in that wiki page.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] cameronlee314 commented on a change in pull request #1295:
SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
cameronlee314 commented on a change in pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r386751213
##########
File path: gradle/maven.gradle
##########
@@ -22,13 +22,13 @@ subprojects {
publishing {
publications {
mavenJava(MavenPublication) {
- from components.java
- if(project.name == 'samza-shell') {
- artifact shellTarGz {
- classifier "dist"
Review comment:
Will there be an impact to the artifact name if `classifier "dist"` is removed here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] DPUkyle commented on a change in pull request #1295:
SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
DPUkyle commented on a change in pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r387192032
##########
File path: gradle/maven.gradle
##########
@@ -22,13 +22,13 @@ subprojects {
publishing {
publications {
mavenJava(MavenPublication) {
- from components.java
- if(project.name == 'samza-shell') {
- artifact shellTarGz {
- classifier "dist"
Review comment:
Verification details.
Before (master branch at 851fc48):
```
$ ./gradlew clean :samza-shell:assemble
$ ls -al samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
-rw-r--r-- 1 kmoore eng 96811 Mar 3 09:48 samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
$ shasum samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
40acd2debccda136a7dee1a2647eb29ddb88df04 samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
```
After (PR branch):
```
$ ./gradlew clean :samza-shell:assemble
$ ls -al samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
-rw-r--r-- 1 kmoore eng 96811 Mar 3 09:50 samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
$ shasum samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
40acd2debccda136a7dee1a2647eb29ddb88df04 samza-shell/build/distributions/samza-shell-1.4.0-SNAPSHOT-dist.tgz
```
Checksums are identical and filenames match, including classifier.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] DPUkyle commented on a change in pull request #1295:
SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
DPUkyle commented on a change in pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r386759972
##########
File path: gradlew.bat
##########
@@ -0,0 +1,84 @@
+@if "%DEBUG%" == "" @echo off
Review comment:
Yes, `gradlew` and `gradlew.bat` are automatically generated by Gradle's [wrapper](https://docs.gradle.org/current/userguide/gradle_wrapper.html) task. You will see subtle changes over the course of Gradle versions as they improve these generated scripts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] cameronlee314 commented on a change in pull request #1295:
SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
cameronlee314 commented on a change in pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r386753381
##########
File path: build.gradle
##########
@@ -866,3 +866,8 @@ project(":samza-test_$scalaSuffix") {
from(configurations.archives.artifacts.files) { into("lib/") }
}
}
+
+// SAMZA-2473 read wrapper version from gradle.properties
+wrapper {
+ gradleVersion = project.gradleVersion
Review comment:
Could you please add a comment in `gradle.properties` right above `gradleVersion` to re-run `./gradlew wrapper` and commit the generated changes when upgrading Gradle in the future?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] cameronlee314 merged pull request #1295: SAMZA-2473:
gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
cameronlee314 merged pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] DPUkyle opened a new pull request #1295: SAMZA-2473:
gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
DPUkyle opened a new pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295
Issues: Gradle wrapper version out-of-sync with properties file
Changes:
1. Fix built-in wrapper task to read value from gradle.properties
2. Update Gradle wrapper to 5.2.1, committing new wrapper scripts and bootstrap jar
3. Left instructions to run `$ ./gradlew wrapper` to update in the future
4. Fix maven publish behavior change; see https://docs.gradle.org/5.2.1/userguide/publishing_maven.html#publishing_maven:deferred_configuration
Tests: Manually verified `samza-shell-<version>-dist.tgz` artifact is unchanged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] DPUkyle closed pull request #1295: SAMZA-2473:
gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
DPUkyle closed pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] DPUkyle commented on a change in pull request #1295:
SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
DPUkyle commented on a change in pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r386769659
##########
File path: gradle/maven.gradle
##########
@@ -22,13 +22,13 @@ subprojects {
publishing {
publications {
mavenJava(MavenPublication) {
- from components.java
- if(project.name == 'samza-shell') {
- artifact shellTarGz {
- classifier "dist"
Review comment:
The artifact produced by task `shellTarGz` already specifies the `dist` classifier: https://github.com/apache/samza/blob/master/build.gradle#L552
Just in case, I'll build again and verify locally.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [samza] cameronlee314 commented on a change in pull request #1295:
SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
Posted by GitBox <gi...@apache.org>.
cameronlee314 commented on a change in pull request #1295: SAMZA-2473: gradleVersion and wrapper jar are out-of-sync
URL: https://github.com/apache/samza/pull/1295#discussion_r386752287
##########
File path: gradlew.bat
##########
@@ -0,0 +1,84 @@
+@if "%DEBUG%" == "" @echo off
Review comment:
Just double checking: This file is automatically generated, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services