You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@ratis.apache.org by "Tsz-wo Sze (Jira)" <ji...@apache.org> on 2022/11/17 12:18:00 UTC

[jira] [Commented] (RATIS-1748) RatisMetricRegistryImpl.getMetricName could be cached to reduce garbage

    [ https://issues.apache.org/jira/browse/RATIS-1748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17635325#comment-17635325 ] 

Tsz-wo Sze commented on RATIS-1748:
-----------------------------------

The master branch already has this fixed.  I guess you were profiling branch-2.

> RatisMetricRegistryImpl.getMetricName could be cached to reduce garbage
> -----------------------------------------------------------------------
>
>                 Key: RATIS-1748
>                 URL: https://issues.apache.org/jira/browse/RATIS-1748
>             Project: Ratis
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Lari Hotari
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In allocation profiling with AsyncProfiler, I can see that RatisMetricRegistryImpl.getMetricName produces unnecessary garbage. It's better to cache the results. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)