You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2021/06/28 10:55:28 UTC

[GitHub] [mynewt-core] kasjer opened a new pull request #2632: nrf5340/i2c: Fix STOP event handling

kasjer opened a new pull request #2632:
URL: https://github.com/apache/mynewt-core/pull/2632


   After read or write that ended with error (address nack)
   interrupts are blocked and stop condition is generated
   that will rise EVENTS_STOP later on.
   
   Read or write finishes with this event active.
   
   On next write or read interrupt were enabled before EVENTS_STOP
   was cleared resulting in interrupt handling that would signal
   semaphore.
   In some cases that may lead to data corruption when code reuses buffer
   while I2C transaction is ongoing.
   
   This changes clears old events before enabling interrupts.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] vrahane commented on pull request #2632: nrf5340/i2c: Fix STOP event handling

Posted by GitBox <gi...@apache.org>.

vrahane commented on pull request #2632:
URL: https://github.com/apache/mynewt-core/pull/2632#issuecomment-870923224


   @vikrant-proxy Tired it out. looks good.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [mynewt-core] vrahane merged pull request #2632: nrf5340/i2c: Fix STOP event handling

Posted by GitBox <gi...@apache.org>.

vrahane merged pull request #2632:
URL: https://github.com/apache/mynewt-core/pull/2632


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org