[jira] [Resolved] (CXF-6689) .close() is never called on org.apache.cxf.transport.http.URLConnectionHTTPConduit

["Daniel Kulp (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/CXF-6689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Daniel Kulp resolved CXF-6689.
------------------------------
       Resolution: Not A Problem
         Assignee: Daniel Kulp
    Fix Version/s: Invalid

I believe this is completely working correctly.   If you "close" the proxy, the underlying conduit closes.   

3.x does make the proxies implement closeable and 3.1 makes them autoclosable.   

> .close() is never called on org.apache.cxf.transport.http.URLConnectionHTTPConduit
> ----------------------------------------------------------------------------------
>
>                 Key: CXF-6689
>                 URL: https://issues.apache.org/jira/browse/CXF-6689
>             Project: CXF
>          Issue Type: Bug
>          Components: JAX-WS Runtime
>    Affects Versions: 2.7.16
>            Reporter: Marco Rietveld
>            Assignee: Daniel Kulp
>             Fix For: Invalid
>
>
> If you look at 
> https://github.com/apache/cxf/blob/cxf-3.1.4/core/src/main/java/org/apache/cxf/endpoint/AbstractConduitSelector.java#L209
> you'll see that only the {{.close(Message)}} method is called on the {{Conduit}} instance. 
> Unfortunately, the only {{.close()}} method that the {{org.apache.cxf.transport.http.URLConnectionHTTPConduit}} has, does not take an argument, which (AFAICT?), means that close is never called on the {{URLConnectionHTTPConduit}} instance. 
> https://github.com/apache/cxf/blob/cxf-3.1.4/rt/transports/http/src/main/java/org/apache/cxf/transport/http/URLConnectionHTTPConduit.java#L87 
> This has consequences, among others, that if you do the following, it will succeed: 
> 1. Create a JAX-WS client proxy with correct login info. 
> 2. Create a JAX-WS client proxy with incorrect login info. 
> In some situations, the following (subsequent to the above steps) step will also succeed: 
> 3. Do a webservice call with the JAX-WS client proxy created with incorrect login info.  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)