You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by lifei <gi...@git.apache.org> on 2015/07/08 19:29:00 UTC

[GitHub] thrift pull request: THRIFT-3230: transform typedef when getting t...

GitHub user lifei opened a pull request:

    https://github.com/apache/thrift/pull/545

    THRIFT-3230: transform typedef when getting type name

    Python compiler generates wrong code if there is function throwing a typedef of exception with another namespace. We should use the real type name instead of  the name of typedef.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lifei/thrift THRIFT-3230

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/545.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #545
    
----
commit 13959081f2e8efbc830a3dd2cd3ebf509373fd99
Author: 软件工程师李飛 <li...@7v1.net>
Date:   2015-07-08T17:23:43Z

    THRIFT-3230: transform typedef when getting type name
    
    Python compiler generates wrong code if there is function throwing a typedef of exception with another namespace. We should use the real type name instead of  the name of typedef.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3230: transform typedef when getting t...

Posted by lifei <gi...@git.apache.org>.
Github user lifei closed the pull request at:

    https://github.com/apache/thrift/pull/545


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3230: transform typedef when getting t...

Posted by lifei <gi...@git.apache.org>.
Github user lifei commented on the pull request:

    https://github.com/apache/thrift/pull/545#issuecomment-120211338
  
    https://issues.apache.org/jira/browse/THRIFT-3230


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-3230: transform typedef when getting t...

Posted by lifei <gi...@git.apache.org>.
Github user lifei commented on the pull request:

    https://github.com/apache/thrift/pull/545#issuecomment-146838596
  
    https://github.com/apache/thrift/commit/01a77ab01e7459d96059a2b49d9885d14a360ef1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---