You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Andrei Savu (JIRA)" <ji...@apache.org> on 2010/08/19 15:07:16 UTC

[jira] Created: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer

Make zookeeper.is_unrecoverable return True or False and not an integer
-----------------------------------------------------------------------

                 Key: ZOOKEEPER-853
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
             Project: Zookeeper
          Issue Type: Improvement
          Components: contrib-bindings
            Reporter: Andrei Savu
            Assignee: Andrei Savu
            Priority: Minor
             Fix For: 3.4.0


This is a patch that fixes a TODO from the python zookeeper extension, it makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an integer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated ZOOKEEPER-853:
----------------------------------

    Status: Patch Available  (was: Open)

> Make zookeeper.is_unrecoverable return True or False and not an integer
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-853.patch
>
>
> This is a patch that fixes a TODO from the python zookeeper extension, it makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an integer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909613#action_12909613 ] 

Hudson commented on ZOOKEEPER-853:
----------------------------------

Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/])
    

> Make zookeeper.is_unrecoverable return True or False and not an integer
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-853.patch, ZOOKEEPER-853.patch
>
>
> This is a patch that fixes a TODO from the python zookeeper extension, it makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an integer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer

Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Robinson updated ZOOKEEPER-853:
-------------------------------------

        Status: Resolved  (was: Patch Available)
    Resolution: Fixed

I just committed this (to trunk) - thanks Andrei!

> Make zookeeper.is_unrecoverable return True or False and not an integer
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-853.patch, ZOOKEEPER-853.patch
>
>
> This is a patch that fixes a TODO from the python zookeeper extension, it makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an integer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12904571#action_12904571 ] 

Andrei Savu commented on ZOOKEEPER-853:
---------------------------------------

Thanks Henry. 

> Make zookeeper.is_unrecoverable return True or False and not an integer
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-853.patch, ZOOKEEPER-853.patch
>
>
> This is a patch that fixes a TODO from the python zookeeper extension, it makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an integer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer

Posted by "Henry Robinson (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Henry Robinson updated ZOOKEEPER-853:
-------------------------------------

    Hadoop Flags: [Reviewed]

+1 This looks good to me - thanks. 

> Make zookeeper.is_unrecoverable return True or False and not an integer
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-853.patch, ZOOKEEPER-853.patch
>
>
> This is a patch that fixes a TODO from the python zookeeper extension, it makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an integer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated ZOOKEEPER-853:
----------------------------------

    Status: Open  (was: Patch Available)

> Make zookeeper.is_unrecoverable return True or False and not an integer
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-853.patch
>
>
> This is a patch that fixes a TODO from the python zookeeper extension, it makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an integer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated ZOOKEEPER-853:
----------------------------------

    Attachment: ZOOKEEPER-853.patch

> Make zookeeper.is_unrecoverable return True or False and not an integer
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-853.patch
>
>
> This is a patch that fixes a TODO from the python zookeeper extension, it makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an integer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated ZOOKEEPER-853:
----------------------------------

    Status: Patch Available  (was: Open)

> Make zookeeper.is_unrecoverable return True or False and not an integer
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-853.patch, ZOOKEEPER-853.patch
>
>
> This is a patch that fixes a TODO from the python zookeeper extension, it makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an integer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-853) Make zookeeper.is_unrecoverable return True or False and not an integer

Posted by "Andrei Savu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-853?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrei Savu updated ZOOKEEPER-853:
----------------------------------

    Attachment: ZOOKEEPER-853.patch

Fixed patch to do proper reference counting when returning boolean values. 

> Make zookeeper.is_unrecoverable return True or False and not an integer
> -----------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-853
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-853
>             Project: Zookeeper
>          Issue Type: Improvement
>          Components: contrib-bindings
>            Reporter: Andrei Savu
>            Assignee: Andrei Savu
>            Priority: Minor
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-853.patch, ZOOKEEPER-853.patch
>
>
> This is a patch that fixes a TODO from the python zookeeper extension, it makes {{zookeeper.is_unrecoverable}} return {{True}} or {{False}} and not an integer. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.