You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2019/11/13 17:03:33 UTC
[GitHub] [commons-dbcp] louislatreille opened a new pull request #35:
DBCP-558 Fix DelegatingConnection readOnly and autoCommit caching mechanism
louislatreille opened a new pull request #35: DBCP-558 Fix DelegatingConnection readOnly and autoCommit caching mechanism
URL: https://github.com/apache/commons-dbcp/pull/35
https://issues.apache.org/jira/browse/DBCP-558
Previously, we would cache the input of setReadOnly and setAutoCommit directly without checking if the underlying connection succeeded in setting the configuration parameter. This would result in wrong results from isReadOnly and getAutoCommit if the underlying connection didn't support read-only/non-read-only or auto-commit/non-auto-commit connections, as with SqlServerConnection.
This fixes the issue by caching what is return by isReadOnly and getAutoCommit from the underlying connection.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services